RPP - Connect the duplicate payment prevention service (Verification)

includes/admin/class-wc-rest-payments-orders-controller.php

@@ -182,7 +182,7 @@ public function capture_terminal_payment( WP_REST_Request $request ) {
 				Logger::error( 'Payment capture rejected due to failed validation: order id on intent is incorrect or missing.' );
 				return new WP_Error( 'wcpay_intent_order_mismatch', __( 'The payment cannot be captured', 'woocommerce-payments' ), [ 'status' => 409 ] );
 			}
-			if ( ! in_array( $intent->get_status(), WC_Payment_Gateway_WCPay::SUCCESSFUL_INTENT_STATUS, true ) ) {
+			if ( ! in_array( $intent->get_status(), Intent_Status::SUCCESSFUL_STATUSES, true ) ) {
 				return new WP_Error( 'wcpay_payment_uncapturable', __( 'The payment cannot be captured', 'woocommerce-payments' ), [ 'status' => 409 ] );
 			}
 
@@ -283,7 +283,7 @@ public function capture_authorization( WP_REST_Request $request ) {
 				Logger::error( 'Payment capture rejected due to failed validation: order id on intent is incorrect or missing.' );
 				return new WP_Error( 'wcpay_intent_order_mismatch', __( 'The payment cannot be captured', 'woocommerce-payments' ), [ 'status' => 409 ] );
 			}
-			if ( ! in_array( $intent->get_status(), WC_Payment_Gateway_WCPay::SUCCESSFUL_INTENT_STATUS, true ) ) {
+			if ( ! in_array( $intent->get_status(), Intent_Status::SUCCESSFUL_STATUSES, true ) ) {
 				return new WP_Error( 'wcpay_payment_uncapturable', __( 'The payment cannot be captured', 'woocommerce-payments' ), [ 'status' => 409 ] );
 			}
 

includes/class-duplicate-payment-prevention-service.php

@@ -100,7 +100,7 @@ public function check_payment_intent_attached_to_order_succeeded( WC_Order $orde
 			return;
 		};
 
-		if ( ! in_array( $intent_status, WC_Payment_Gateway_WCPay::SUCCESSFUL_INTENT_STATUS, true ) ) {
+		if ( ! in_array( $intent_status, Intent_Status::SUCCESSFUL_STATUSES, true ) ) {
 			return;
 		}
 

includes/class-wc-payment-gateway-wcpay.php

@@ -32,6 +32,8 @@
 use WCPay\Duplicate_Payment_Prevention_Service;
 use WCPay\Fraud_Prevention\Fraud_Prevention_Service;
 use WCPay\Fraud_Prevention\Fraud_Risk_Tools;
+use WCPay\Internal\Payment\State\PreviousPaidOrderDetectedState;
+use WCPay\Internal\Service\DuplicatePaymentPreventionService;
 use WCPay\Logger;
 use WCPay\Payment_Information;
 use WCPay\Payment_Methods\UPE_Payment_Gateway;
@@ -90,17 +92,6 @@ class WC_Payment_Gateway_WCPay extends WC_Payment_Gateway_CC {
 		'deposit_schedule_monthly_anchor'    => 'deposit_schedule_monthly_anchor',
 	];
 
-	/**
-	 * Stripe intents that are treated as successfully created.
-	 *
-	 * @type array
-	 */
-	const SUCCESSFUL_INTENT_STATUS = [
-		Intent_Status::SUCCEEDED,
-		Intent_Status::REQUIRES_CAPTURE,
-		Intent_Status::PROCESSING,
-	];
-
 	const UPDATE_SAVED_PAYMENT_METHOD = 'wcpay_update_saved_payment_method';
 
 	/**
@@ -819,6 +810,14 @@ public function new_process_payment( WC_Order $order ) {
 		$service = wcpay_get_container()->get( PaymentProcessingService::class );
 		$state   = $service->process_payment( $order->get_id(), $manual_capture );
 
+		if ( $state instanceof PreviousPaidOrderDetectedState ) {
+			return [
+				'result'   => 'success',
+				'redirect' => $this->get_return_url( $order ), // TODO: This should be PaymentContext::get_previous_order_id(). But how to get it as we do expose PaymentContext here at the moment.
+				DuplicatePaymentPreventionService::FLAG_PREVIOUS_ORDER_PAID => 'yes',
+			];
+		}
+
 		if ( $state instanceof CompletedState ) {
 			return [
 				'result'   => 'success',
@@ -1383,7 +1382,7 @@ public function process_payment_for_order( $cart, $payment_information, $schedul
 		}
 
 		if ( ! empty( $intent ) ) {
-			if ( ! in_array( $status, self::SUCCESSFUL_INTENT_STATUS, true ) ) {
+			if ( ! in_array( $status, Intent_Status::SUCCESSFUL_STATUSES, true ) ) {
 				$intent_failed = true;
 			}
 
@@ -2972,7 +2971,7 @@ public function update_order_status() {
 			}
 			$this->order_service->update_order_status_from_intent( $order, $intent );
 
-			if ( in_array( $status, self::SUCCESSFUL_INTENT_STATUS, true ) ) {
+			if ( in_array( $status, Intent_Status::SUCCESSFUL_STATUSES, true ) ) {
 				wc_reduce_stock_levels( $order_id );
 				WC()->cart->empty_cart();
 

includes/constants/class-intent-status.php

@@ -26,4 +26,15 @@ class Intent_Status extends Base_Constant {
 	const REQUIRES_CAPTURE        = 'requires_capture';
 	const CANCELED                = 'canceled';
 	const SUCCEEDED               = 'succeeded';
+
+	/**
+	 * Stripe intents that are treated as successfully created.
+	 *
+	 * @type array
+	 */
+	const SUCCESSFUL_STATUSES = [
+		self::SUCCEEDED,
+		self::REQUIRES_CAPTURE,
+		self::PROCESSING,
+	];
 }

src/Internal/DependencyManagement/ServiceProvider/GenericServiceProvider.php

@@ -14,6 +14,7 @@
 use WCPay\Internal\Proxy\LegacyProxy;
 use WCPay\Internal\Service\Level3Service;
 use WCPay\Internal\Service\OrderService;
+use WCPay\Internal\Service\SessionService;
 
 /**
  * WCPay payments generic service provider.
@@ -45,5 +46,8 @@ public function register(): void {
 			->addArgument( OrderService::class )
 			->addArgument( WC_Payments_Account::class )
 			->addArgument( LegacyProxy::class );
+
+		$container->addShared( SessionService::class )
+			->addArgument( LegacyProxy::class );
 	}
 }

src/Internal/DependencyManagement/ServiceProvider/PaymentsServiceProvider.php

@@ -17,15 +17,19 @@
 use WCPay\Internal\Payment\State\CompletedState;
 use WCPay\Internal\Payment\State\InitialState;
 use WCPay\Internal\Payment\State\PaymentErrorState;
+use WCPay\Internal\Payment\State\PreviousPaidOrderDetectedState;
 use WCPay\Internal\Payment\State\StateFactory;
 use WCPay\Internal\Payment\State\SystemErrorState;
+use WCPay\Internal\Proxy\HooksProxy;
 use WCPay\Internal\Proxy\LegacyProxy;
+use WCPay\Internal\Service\DuplicatePaymentPreventionService;
 use WCPay\Internal\Service\PaymentProcessingService;
 use WCPay\Internal\Service\ExampleService;
 use WCPay\Internal\Service\ExampleServiceWithDependencies;
 use WCPay\Internal\Service\Level3Service;
 use WCPay\Internal\Service\OrderService;
 use WCPay\Internal\Service\PaymentRequestService;
+use WCPay\Internal\Service\SessionService;
 
 /**
  * WCPay payments service provider.
@@ -47,6 +51,7 @@ class PaymentsServiceProvider extends AbstractServiceProvider {
 		ExampleService::class,
 		ExampleServiceWithDependencies::class,
 		PaymentRequestService::class,
+		DuplicatePaymentPreventionService::class,
 	];
 
 	/**
@@ -64,12 +69,21 @@ public function register(): void {
 
 		$container->addShared( PaymentRequestService::class );
 
+		$container->addShared( PaymentRequestService::class );
+
+		$container->addShared( DuplicatePaymentPreventionService::class )
+			->addArgument( OrderService::class )
+			->addArgument( SessionService::class )
+			->addArgument( HooksProxy::class )
+			->addArgument( LegacyProxy::class );
+
 		$container->add( InitialState::class )
 			->addArgument( StateFactory::class )
 			->addArgument( OrderService::class )
 			->addArgument( WC_Payments_Customer_Service::class )
 			->addArgument( Level3Service::class )
-			->addArgument( PaymentRequestService::class );
+			->addArgument( PaymentRequestService::class )
+			->addArgument( DuplicatePaymentPreventionService::class );
 
 		$container->add( CompletedState::class )
 			->addArgument( StateFactory::class );
@@ -80,6 +94,9 @@ public function register(): void {
 		$container->add( PaymentErrorState::class )
 			->addArgument( StateFactory::class );
 
+		$container->add( PreviousPaidOrderDetectedState::class )
+			->addArgument( StateFactory::class );
+
 		$container->addShared( Router::class )
 			->addArgument( Database_Cache::class );
 

src/Internal/Payment/PaymentContext.php

@@ -245,4 +245,24 @@ public function set_customer_id( string $customer_id ) {
 	public function get_customer_id(): ?string {
 		return $this->get( 'customer_id' );
 	}
+
+	/**
+	 * Set the previous paid order ID.
+	 *
+	 * @param  int $paid_session_order_id Paid session order ID.
+	 *
+	 * @return void
+	 */
+	public function set_previous_order_id( int $paid_session_order_id ) {
+		$this->set( 'previous_paid_order_id', $paid_session_order_id );
+	}
+
+	/**
+	 * Gets the previous paid order ID.
+	 *
+	 * @return int|null
+	 */
+	public function get_previous_order_id(): ?int {
+		return $this->get( 'previous_paid_order_id' );
+	}
 }

src/Internal/Payment/State/InitialState.php

@@ -8,6 +8,7 @@
 namespace WCPay\Internal\Payment\State;
 
 use WC_Payments_Customer_Service;
+use WCPay\Internal\Service\DuplicatePaymentPreventionService;
 use WCPay\Vendor\League\Container\Exception\ContainerException;
 use WCPay\Internal\Payment\Exception\StateTransitionException;
 use WCPay\Internal\Service\OrderService;
@@ -53,43 +54,59 @@ class InitialState extends AbstractPaymentState {
 	 */
 	private $payment_request_service;
 
+	/**
+	 * Duplicate Payment Prevention service.
+	 *
+	 * @var DuplicatePaymentPreventionService
+	 */
+	private $dpps;
+
 	/**
 	 * Class constructor, only meant for storing dependencies.
 	 *
-	 * @param StateFactory                 $state_factory           Factory for payment states.
-	 * @param OrderService                 $order_service           Service for order-related actions.
-	 * @param WC_Payments_Customer_Service $customer_service        Service for managing remote customers.
-	 * @param Level3Service                $level3_service          Service for Level3 Data.
-	 * @param PaymentRequestService        $payment_request_service Connection with the server.
+	 * @param StateFactory                      $state_factory           Factory for payment states.
+	 * @param OrderService                      $order_service           Service for order-related actions.
+	 * @param WC_Payments_Customer_Service      $customer_service        Service for managing remote customers.
+	 * @param Level3Service                     $level3_service          Service for Level3 Data.
+	 * @param PaymentRequestService             $payment_request_service Connection with the server.
+	 * @param DuplicatePaymentPreventionService $dpps                    Service for preventing duplicate payments.
 	 */
 	public function __construct(
 		StateFactory $state_factory,
 		OrderService $order_service,
 		WC_Payments_Customer_Service $customer_service,
 		Level3Service $level3_service,
-		PaymentRequestService $payment_request_service
+		PaymentRequestService $payment_request_service,
+		DuplicatePaymentPreventionService $dpps
 	) {
 		parent::__construct( $state_factory );
 
 		$this->order_service           = $order_service;
 		$this->customer_service        = $customer_service;
 		$this->level3_service          = $level3_service;
 		$this->payment_request_service = $payment_request_service;
+		$this->dpps                    = $dpps;
 	}
 
 	/**
-	 * Initialtes the payment process.
+	 * Initiates the payment process.
 	 *
 	 * @param PaymentRequest $request    The incoming payment processing request.
-	 * @return CompletedState            The next state.
+	 * @return AbstractPaymentState       The next state.
 	 * @throws StateTransitionException  In case the completed state could not be initialized.
 	 * @throws ContainerException        When the dependency container cannot instantiate the state.
 	 * @throws Order_Not_Found_Exception Order could not be found.
 	 * @throws PaymentRequestException   When data is not available or invalid.
 	 */
 	public function process( PaymentRequest $request ) {
-		$context  = $this->get_context();
-		$order_id = $context->get_order_id();
+		$context               = $this->get_context();
+		$order_id              = $context->get_order_id();
+		$paid_session_order_id = $this->dpps->get_paid_session_processing_order( $order_id );
+		if ( ! is_null( $paid_session_order_id ) ) {
+			// TODO: move the add note, and order deletion from get_paid_session_processing_order to here.
+			$context->set_previous_order_id( $paid_session_order_id );
+			return $this->create_state( PreviousPaidOrderDetectedState::class );
+		}
 
 		// Populate basic details from the request.
 		$this->populate_context_from_request( $request );

src/Internal/Payment/State/PreviousPaidOrderDetectedState.php

@@ -0,0 +1,15 @@
+<?php
+/**
+ * Class PreviousPaidOrderDetectedState
+ *
+ * @package WooCommerce\Payments
+ */
+
+namespace WCPay\Internal\Payment\State;
+
+/**
+ * State used when a recent previous paid order from the same customer with the same cart hash is detected.
+ */
+class PreviousPaidOrderDetectedState extends AbstractPaymentState {
+
+}