Enable transaction dispute details feature for all merchants (remove feature flag) #7365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -622 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Jinksi
commented
Oct 4, 2023
| { ignore: '.a11y-speak-region' } | ||
| ) | ||
| ).toBeNull(); | ||
| test( 'renders the information of a dispute-reversal charge', () => { |
There was a problem hiding this comment.
This is not a new test, simply moved down in this file to group dispute-related tests.
haszari
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Did a quick test of various dispute flows after deleting feature flag.
% docker-compose exec wordpress wp --allow-root option delete _wcpay_feature_dispute_on_transaction_page
Success: Deleted '_wcpay_feature_dispute_on_transaction_page' option.
% docker-compose exec wordpress wp --allow-root option get _wcpay_feature_dispute_on_transaction_page
Error: Could not get '_wcpay_feature_dispute_on_transaction_page' option. Does it exist?
%
- View payments overview, click
You have many disputesnotice, land on disputes list. - Click a dispute, land on relevant transaction with inline dispute info (via redirect spinner). I tested inquiries and disputes with a range of dates.
- Inquiry:
- Click
Submit evidence, land on dispute response form. - Click
Issue refund, shows a modal, can click through to relevant order.
- Click
- Dispute:
- Click
Challenge dispute, land on dispute response form. - Click
Accept dispute, shows a modal.- Click
Accept dispute, eventually shows transaction detail with resolved dispute state.
- Click
- Click
I didn't search the code for the feature flag – assuming you've done that :)
One blocker (IMO):
- Delete
LegacyDisputeDetailsPage, no longer needed.
Some minor design notes, might want to log follow up maintenance issues:
- Extra line at bottom of respond steps, e.g. between
Submit evidence or issue a refundand action buttons. This may be as designed, feels disconnected/cluttered. I wonder if we need lines between steps at all. Accept disputeflow is a little disconnected, might benefit from a transition or spinner after the modal.
@nikkivias FYI – design feedback / notes for your consideration
| Significance: major | ||
| Type: add | ||
|
|
||
| Display dispute information, recommended resolution steps, and actions directly on the transaction details screen to help merchants with dispute resolution. |
| container: isDisputeOnTransactionPageEnabled | ||
| ? RedirectToTransactionDetails | ||
| : LegacyDisputeDetailsPage, | ||
| container: RedirectToTransactionDetails, |
There was a problem hiding this comment.
We can also remove LegacyDisputeDetailsPage completely.
There was a problem hiding this comment.
I believe this is being handled in #7363 and is OK to merge after 6.6.
Agreed! This came up in our UX review. I will log an issue for this if it hasn't been created already. |
Probably ok to leave that with product / design and let it come up as a project / maintenance via normal process. GitHub is best for things we know we want to prioritise. |
Jinksi
deleted the
add/7289-remove-transaction-dispute-details-feature-flag
branch
|
Note this PR has resulted in some failing e2e tests. These tests are being skipped in #7088. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7289
Changes proposed in this Pull Request
This PR enables the transaction dispute details feature for all merchants by removing the feature flag
_wcpay_feature_dispute_on_transaction_page.TODO:
Display dispute information, recommended resolution steps, and actions directly on the transaction details screen to help merchants with dispute resolution.Post-merge:
Before
After
Testing instructions
_wcpay_feature_dispute_on_transaction_pageif previously enableddelete_option( '_wcpay_feature_dispute_on_transaction_page' )npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge