Now the setup intents ids are no more a link to the transaction page #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardola
requested review from
a team,
alefesouza and
hsingyuc
and removed request for
a team and
alefesouza
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
leonardola
changed the title
|
@leonardola When I tested with the free trial, I don't see the payment intent id and if I test without the free trial the payment intent id prefix is not with the free trial without the free trial |
|
@hsingyuc payment intents
Have you used a credit card that was already registered? You'll need to use a brand new credit card for this. Otherwise the setup intent won't show up. Not sure if it should though |
leonardola
force-pushed
the
fix/setup-intent-link
branch
from
35b7379 to
72b5587
Compare
hsingyuc
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
and check out with a new card.
Thank you @leonardola and sorry, I missed this part. Tests are as expected, and LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6577
Changes proposed in this Pull Request
This PR removes the link to setup intents because the transaction page does not support setup intents
Testing instructions
seti_id is not a linknpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge