-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the feature flag check for pay-for-order flow #7296
Add the feature flag check for pay-for-order flow #7296
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. WooPay button is only displayed for pay-for-orders when the feature is enabled via dev tools.
Approving, but let's use the PAY_FOR_ORDER_FLOW
constant you defined instead of the string :)
2c8862a
to
4953b3b
Compare
Changes proposed in this Pull Request
This PR adds the feature flag check for pay-for-order flow. Due to WooCommerce
8.2
doesn't include the order and checkout order endpoints in WooCommerce Blocks. When WooPay upgrades WooCommerce to8.3
, which includes the two endpoints in WooCommerce Blocks11.2.0
, we can remove the feature flag check.Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge