Add correct inquiry docs link to active dispute/inquiry notice in transactions screen #7277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 25, 2023 15:07
+ rename dispute reason variable for clarity
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +10 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
haszari
commented
Sep 25, 2023
| @@ -70,7 +70,7 @@ const DisputeAwaitingResponseDetails: React.FC< Props > = ( { | |||
| <CardBody className="transaction-details-dispute-details-body"> | |||
| <DisputeNotice | |||
| dispute={ dispute } | |||
| urgent={ countdownDays <= 2 } | |||
| isUrgent={ countdownDays <= 2 } | |||
There was a problem hiding this comment.
I've renamed this to isUrgent so it's super obvious it's a boolean. I'm not sure if we have a relevant guideline but this is common in WP code (is my understanding).
I saw isDismissible in block editor JS guidelines so this seems aligned with convention.
haszari
commented
Sep 25, 2023
| let noticeText = __( | ||
| '<strong>%s</strong> Challenge the dispute if you believe the claim is invalid, ' + | ||
| 'or accept to forfeit the funds and pay the dispute fee. ' + | ||
| 'Non-response will result in an automatic loss. <a>Learn more about responding to disputes</a>', |
There was a problem hiding this comment.
Split these over multiple lines so we don't need to eslint-disable-next-line-max-len. Also for readability.
haszari
commented
Sep 25, 2023
| 'https://woocommerce.com/document/woopayments/fraud-and-disputes/managing-disputes/#responding'; | ||
|
|
||
| if ( isInquiry( dispute ) ) { | ||
| /* translators: <a> link to dispute inquiry documentation. %s is the clients claim for the dispute, eg "The cardholder claims this is an unrecognized charge." */ |
There was a problem hiding this comment.
This block overrides the string + url for inquiries. Hopefully makes this easier to read/understand – default is dispute, details are overridden for inquiries.
haszari
commented
Sep 25, 2023
| } ) => { | ||
| const clientClaim = | ||
| const shopperDisputeReason = |
There was a problem hiding this comment.
Renamed this, claim is less clear than dispute reason IMO. The claim is part of the reason, and we're displaying it in the UI as a reason as much as a "claim". We use reason more often so hopefully this is clearer.
…n-transaction-detail
|
Note mobile is a little tight – boxes within boxes. 
We've discussed options with @nikkivias – this might be a follow up. Edit: related issue below, though it's just for minor adjustments. |
Jinksi
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
This tests well @haszari 🙌.
I've confirmed that the links render with the external link icon and on click open the relevant documentation page in a new tab/window for both Disputes (needs_response) and Inquiries (warning_needs_response).
I've left some minor non-blocking suggestions/comments.
Note: I hope you don't mind, I removed an unused isAwaitingResponse import in commit af3d03a – although this wasn't introduced in this PR: see #7231.
| Significance: patch | ||
| Type: fix | ||
|
|
||
| Update documentation links (new/changed docs content) when notifying merchant that a dispute needs response. |
There was a problem hiding this comment.
Should this be a "comment" changelog entry since it's behind a feature flag and not visible to users?
Suggested change
| Update documentation links (new/changed docs content) when notifying merchant that a dispute needs response. | |
| Comment: Behind a feature flag: Update documentation links (new/changed docs content) when notifying merchant that a dispute needs response. |
There was a problem hiding this comment.
Good point 😄 7dc77b0
…n-transaction-detail
Co-authored-by: Eric Jinks <[email protected]>
|
Merging. The failed check is a WooCommerce compatibility check, and it's failing because the environment PHP version is too old (needs to be updated). |
haszari
deleted the
fix/7241-update-live-dispute-docs-links-in-transaction-detail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7241
Changes proposed in this Pull Request
This PR updates the docs links in the "you have a dispute you need to respond to" notice displayed in the transaction detail screen.
There are two links, one for disputes and one for inquiries (aka pre-dispute inquiries).
This PR also adds the "external link" icon since these docs are not in a modal/popup or hosted on merhant's store. This also gives a clue that they will open in a new tab/window, which can be confusing (especially on mobile).
And some refactoring
I've done some light refactoring to clarify the code while here. Will add inline review comments to explain. Happy to revert if this is disruptive.
Testing instructions
Dashboard > Transactionsand click on the relevant transaction row to view details.Example screenshots:
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge