Add shopper Tracks events #7268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +6.14 kB (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
malithsen
requested review from
a team and
alefesouza
and removed request for
a team
alefesouza
reviewed
Oct 5, 2023
Comment on lines
56
to
63
| const onPaymentRequestButtonClick = () => { | ||
| console.log( 'clicked' ); | ||
| onButtonClick(); | ||
| }; | ||
|
|
||
| return ( | ||
| <PaymentRequestButtonElement | ||
| onClick={ onButtonClick } | ||
| onClick={ onPaymentRequestButtonClick } |
There was a problem hiding this comment.
🤦 Thanks for catching that!
I had some uncommitted changes. To test them please follow instructions under "Payment Request Buttons" on the Blocks checkout page.
There was a problem hiding this comment.
@alefesouza I am requesting another review due to the above changes :)
alefesouza
approved these changes
Oct 5, 2023
alefesouza
approved these changes
Oct 7, 2023
|
Thanks @alefesouza fixed the event name in 0287dc7 |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/woopay/issues/1907
Changes proposed in this Pull Request
This PR adds the following Tracks events
Testing instructions
Save My Info events
wcpay_checkout_woopay_save_my_info_tooltip_hover)wcpay_checkout_save_my_info_tos_click,wcpay_checkout_woopay_save_my_info_privacy_policy_click)Payment Request Buttons
wcpay_gpay_button_clickandwcpay_apple_pay_button_clickwith the relevantsourceproperty indicating the page.Page Views
wcpay_cart_page_viewandwcpay_product_page_viewevents.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge