Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dispute steps to resolve to the transaction details page. #7206
Add dispute steps to resolve to the transaction details page. #7206
Changes from 30 commits
bb6ba35
3088de5
284243f
18f2fa5
5a3cbe5
53c6679
f9c94f9
45e25fa
63bd71f
6fe270b
d28219e
04ee3f6
e94f356
a7ddf94
116a8db
ad54e79
6e2b7ff
d9d006e
e8a83fe
f9126c5
d105ead
19545bd
973a63c
64556a1
0b768b3
6a55603
3d35ecc
787b8d9
341ef80
0498f7a
4a10c2a
9275269
71a3349
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to use querystring.strinfigy() but I don't see it's used at all in the codebase, so I just use
encodeURIComponent()
to escape each param's value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has anyone tested clicking the link correctly works with at least one email client? If there's any issue with escaping or protocol then that would catch it! I have this behaviour disabled on my mac (because I use GMail), so wasn't able to test.
Noting so we can test in our test swarm today e.g. on mobile or if someone has
mailto
configured right :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found these inline icon tooltips a bit weird, they break the flow of the sentence. It's functioning well though and super clear and usable so not a blocker.
Maybe that info could be in a single help popup, nearer the action buttons. Thinking out loud – @nikkivias is our UX expert here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from DisputeSummaryRow's so it looks consistent.
One doubt I have is that in the design paJDYF-9Ip-p2, when due date is still more than 7-day away, it does not show the
({n} days left to respond)
part.but I see in
DisputeSummaryRow
, it shows that text, so for consistency sake, I followDisputeSummaryRow
.