Fix incorrect payment intent status check in cancel authorization API endpoint. #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Change looks good @zmaglica, thanks for working on it and creating a separate issue. Do we have any tests associated with this change that you plan to add?
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
htdat
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Thanks for working on this @zmaglica! Pre-approve this PR.
@eduardoumpierre - it would be great if you can test this issue in your site too to confirm it's working as expected. I am looking further in the code using this endpoint cancel_authorization, it seems it's used together with the Fraud check to display the CancelAuthorizationButton component in the transaction detail page.
woocommerce-payments/client/payment-details/summary/index.tsx
Lines 295 to 297 in 83f6905
eduardoumpierre
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
I followed the testing instructions and it worked as expected – it fixed the bad response. The change makes sense and it's covered by tests.
Thanks for working on this @zmaglica! LGTM 
@htdat Regarding the CancelAuthorizationButton logic, it is currently inaccessible for the merchants, as the review feature was removed from FRT phase 1. We can test it by forcing the application to understand the order as it is held for review, which can be done by applying the diff below.
diff --git a/client/utils/charge/index.ts b/client/utils/charge/index.ts
index 2690279e2..7c3e7ff7d 100755
--- a/client/utils/charge/index.ts
+++ b/client/utils/charge/index.ts
@@ -65,6 +65,8 @@ export const isOnHoldByFraudTools = (
charge?: Charge,
paymentIntent?: PaymentIntent
): boolean => {
+ return true;
+
const fraudMetaBoxType = getFraudMetaBoxType( charge, paymentIntent );
if ( ! fraudMetaBoxType ) {
zmaglica
deleted the
fix/7149-fix-cancel-authorization-flaky-error-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7149
Changes proposed in this Pull Request
The incorrect payment intent status was utilized, leading to an error response rather than a successful one.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge