Add Transaction Details notice when a dispute has staged evidence #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +222 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
…lenge-in-progress-notice
When the Dispute is nested within a Charge, the charge property is a charge id (ch_) rather than a dispute object.
Jinksi
commented
Sep 7, 2023
| @@ -51,7 +64,7 @@ export interface Dispute { | |||
| evidence: Evidence; | |||
| fileSize?: Record< string, number >; | |||
| reason: DisputeReason; | |||
| charge: Charge; | |||
| charge: Charge | string; | |||
There was a problem hiding this comment.
When the Dispute is nested within a Charge, the charge property is a charge id string (ch_) rather than a dispute object.
brucealdridge
approved these changes
Sep 7, 2023
Jinksi
deleted the
add/6966-transaction-details-dispute-challenge-in-progress-notice
branch
This was referenced Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6966
Changes proposed in this Pull Request
This PR adds a notice to the Transaction Details screen when the dispute associated with the transaction has staged evidence (i.e. the merchant has clicked "Save for later" on the dispute challenge form). This notice reminds the merchant that they have a draft response to the dispute.
I've also added a test suite for
DisputeDetails, a copy of the test suite implemented in the WIP PR #7093.Testing instructions
update_option( '_wcpay_feature_dispute_on_transaction_page', '1' );in WP Console or by modifying your database tablewp_optionsdirectly.4000000000000259at checkout.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge