Update Subscriptions with WooPayments eligibility as we move to deprecate this functionality #7117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +14 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
mattallan
commented
Sep 11, 2023
|
@mattallan there's a conflict on this PR due to the changes to |
james-allan
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Works for me and changes look good.
- Not eligible - No subscriptions or products
- Eligible
- Subscription
- Product
- Upgrade flow. Enabled → updated → not eligible → disabled
- Upgrade flow. Enabled → updated → eligible → enabled
- Setting hidden when Woo Subscriptions is active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6510
Changes proposed in this Pull Request
As part of the Subscriptions Primary Offering project, we need to deprecate the existing WCPay Subscriptions feature so that merchants can opt into the new subscriptions setting.
In this PR we are updating the eligibility of the WCPay Subscriptions so that we:
To meet these new requirements I've changed
is_wcpay_subscriptions_eligible()to only return true when:Testing instructions
Testing this PR requires toggling the following:
_wcpay_subscription_idmetadata)With that information, here are the testing instructions to toggle through most of the new eligibility cases:
_wcpay_subscription_idto something like_wcpay_subscription_id_test_wcpay_subscription_idmeta.With these instructions I have tested the following cases:
__wcpay_subscriptions_idmeta (including pending, canceled, on-hold etc.)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge