Migrate link-item to typescript #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -14.6 kB (-1%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
@ismaeldcom I've updated the target in tsconfig to ES6, can you please check it once. |
6 tasks
|
Hey @naman03malhotra! I wonder what's the use case for the tsconfig target update. I see The target option in TS config stand for which target of JavaScript will be emitted, but doesn't affect which TS/JS features we can use while coding. Although, with our current browser support it's probably okay to start targeting ES6 instead of ES5 🙂 |
With the target as ES5, ts throws an error regarding the usage of ES6 goodies. There are other ways to solve it, but I found this the recommended way. |
|
This what you get when using spread operator with ES5 as target. I think it should be safe to update the target to ES6 with the present browser support. |
ismaeldcom
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Oh! I thought it was due to the use of the spread operator, but it's due to the iteration of Set. Yep, updating the target to ES6 is probably the easiest way to do it.
I just checked our current supported browsers, and can confirm that it's safe to use ES6 from now on 🙂
|
@ismaeldcom can you please take a look at #7081 which is an extension of this PR :) |
zmaglica
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7052
Changes proposed in this Pull Request
link-item.jsto typescript.es6intsconfigto allow spread operator.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge