-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPP - Payment request class for loading, sanitizing, and escaping data #7054
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
@RadoslavGeorgiev - I've changed the approach. It would be great if you can have a look, and see if the new direction looks ok? I am still working on other utils for now. |
It looks great now! Looking forward to seeing the rest of the class :) |
Ready for the first round of review. I checked $_POST in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! just a couple of minor nitpicks on my side.
I love seeing how we're trying to hack validation in tests :)
@RadoslavGeorgiev - Thanks for all great feedback. I've addressed all of them. Ready for another review round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for fixing my nitpicks!
Note: RPP = Re-engineering Payment Process.
Fixes #6684
Changes proposed in this Pull Request
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge