Add support for kanji and kana statement descriptors #7051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +675 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
anu-rock
reviewed
Aug 28, 2023
There was a problem hiding this comment.
The code looks good. The happy path worked well in manual testing. One edge case failed.
Review checklist
| Parameter | Result |
|---|---|
| Approach | ✅ All good |
| Implementation | ✅ All good |
| Automated tests | ✅ All good |
| Naming | ✅ All good |
| Typing | ✅ All good |
| Code comments | ✅ All good |
| Changelog | ✅ All good |
| Testing instructions | 👍 Almost good (we can also add instructions to try saving the fields) |
| Manual testing | ✅ Works as expected |
| Edge cases | ❌ Failed (see below) |
Scenarios tested
| Scenario | Result |
|---|---|
| Visibility of Kanji and Kana statement descriptor fields for a JP account | ✅ Visible |
| Visibility of Kanji and Kana statement descriptor fields for a US account | ✅ Not visible |
| Save settings on inputting valid values in the new fields | ✅ Settings saved successfully (verified after page refresh) |
| Save settings on inputting invalid values in the new fields (Latin characters in Kana field) | ❌ Settings saved successfully (found old values on page refresh). Ideally, an error should be thrown and saving should fail. |
|
Since the texts "Edit the way your store name appears on your customers' bank statements." appears under each input, would be a good ideea to move it on top ? @elizaan36, could you please share your opinion on this ? |
elazzabi
approved these changes
Aug 29, 2023
mordeth
approved these changes
Aug 29, 2023
|
Moving that line to the top looks good but I think the section title should be "Customer statements". We can keep the "Customer support" section below for email and phone. 
One small thing "You must only use Kanji letters" is repeated and 2nd one should say Kana. I updated the text to "Use only [language] letters." Can we detect the store language setting rather than using the word "Latin"? I'm afraid "Latin" won't make much sense to merchants and could be confusing. |
added 2 commits
August 31, 2023 16:15
…mmerce-payments into add/6874-add-kanji-kana
anu-rock
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
LGTM after latest changes 🎉
IMO, we should make one last small change. The names for all three fields now read the same, making them appear redundant. I think they should be:
Customer bank statement
Customer bank statement (kanji)
Customer bank statement (kana)
Pre-approving the changes ✅
(Noting that my edge case issue about the error in saving with incorrect characters will be tackled separately in #7090.)
@elizaan36 , as you mentioned |
added 2 commits
August 31, 2023 17:49
…mmerce-payments into add/6874-add-kanji-kana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6874
Changes proposed in this Pull Request
For JP Stripe accounts, add statement descriptors for kana and kanji.
Under the latin statement descriptor, if it's a JP stripe account, we need to show another 2 inputs for kana and kanji statement descriptors.
Max length for kanji - 17 chars
Max length for kana - 22 chars
Testing instructions
Transactionssection, the inputs for kana and kanji statement descriptors should be present under the latin statement descriptor inputnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge