Automatically update the local WCPay Dev Tools clone to use the latest on trunk #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools when on trunk
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
dmallory42
approved these changes
May 16, 2023
There was a problem hiding this comment.
This is awesome, nice work @vladolaru! Tested and it works perfectly as described in the instructions.
One small note - this probably wouldn't work for the folks who don't use Docker like @ismaeldcom - it may be worth either allowing the DEV_TOOLS_PATH to be configurable (without tracking the change, for example having it in a local config file) with the default value being the Docker path, so they can point it at their local dev tools path if needed.
Approving the PR, feel free to 
once you take a look at that small detail!
|
Thank you, @dmallory42! I added support for |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6311
Changes proposed in this Pull Request
We upgrade the Husky
post-mergeandpost-checkouthooks to automatically pull the latest trunk changes on the local WCPay Dev Tools clone.To keep the behavior safe, this will only happen if:
trunkbranchHere are some screenshots of the command line messaging when doing a
git checkouton the local WCPay client:Testing instructions
git fetch && git checkout dev/6311-automatically-update-wcpay-dev-toolscd docker/wordpress/wp-content/plugins/woocommerce-payments-dev-tools && git checkout trunk && git pullgit checkout; after the composer messaging, you should see messaging around attempting to update for the WCPay Dev Tools plugin; the final line should say "Already up to date."git checkout; after the composer messaging, you should see messaging around attempting to update for the WCPay Dev Tools plugin; the final line should say: "There are uncommitted local changes on the WCPay Dev Tools repo. Skipping any attempt to update it.";trunk(for exampleupdate/reorganize-cleanup-document-dev-tools-options)git checkout; after the composer messaging, you should see messaging around attempting to update for the WCPay Dev Tools plugin; the final line should say: "The WCPay Dev Tools local clone is not on the trunk branch. Skipping any attempt to update it.";git reset --hard 700b195cad544bdbf52f5139dd427aada05a9bdd)git checkout; after the composer messaging, you should see messaging around attempting to update for the WCPay Dev Tools plugin; the final lines should be git's messaging around updating and fast-forwarding;npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge