Handle forwarded "account.updated" webhook #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic is required by other parts of the code base, so extracting it out allows it to be shared. The unit tests have been left as is for now, but this also allows for database access to be mocked more easily.
The initial implementation just handles refund updated events and adds an order note in the event of a failure.
This rule is generating some false positives. We can try turning it on again if it gets fixed in a later PHPCS version. Alternatively we could start relying on a static code analyser for more robust checks on how we're using exceptions.
vbelolapotkov
changed the title
allendav
reviewed
Apr 17, 2020
| array( | ||
| 'methods' => WP_REST_Server::CREATABLE, | ||
| 'callback' => array( $this, 'handle_webhook' ), | ||
| 'permission_callback' => array( $this, 'check_permission' ), |
There was a problem hiding this comment.
check_permission will be interesting. How will you do it?
There was a problem hiding this comment.
According to #411 (comment), the existing check should be enough because it will log in the connection owner via the signature in the request (see also paJDYF-wq-p2).
|
Looks like you're including a refactor to make it more unit testable too? That's awesome, but if this PR gets much larger let's do that as a separate PR |
vbelolapotkov
force-pushed
the
add/512-handle-account-updated-webhook
branch
from
831c326 to
d3e0817
Compare
vbelolapotkov
changed the base branch from
master
to
add/handling-for-failed-refunds
jrodger
force-pushed
the
add/handling-for-failed-refunds
branch
from
1d1ee4d to
e2fcaff
Compare
vbelolapotkov
changed the base branch from
add/handling-for-failed-refunds
to
master
1 task
|
Replaced with #612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512
Based on webhooks forwarding introduced in #411
Changes proposed in this Pull Request
Questions:
Testing instructions
Run unit tests with
./vendor/bin/phpunit.Setup testing environment:
Testing steps:
account.updatedwebhook is logged.