E2E Playwright Migration: convert Admin Disputes spec #10123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
eduardoumpierre
approved these changes
Jan 14, 2025
Comment on lines
26
to
32
| expect( | ||
| page | ||
| .getByRole( 'heading', { | ||
| name: 'Disputes', | ||
| } ) | ||
| .nth( 1 ) | ||
| ).toBeVisible(); |
There was a problem hiding this comment.
Nitpick: This part is a bit hard to read. One way to improve that would be to remove the extra comma after "Disputes", so it can be formatted in a single line.
Suggested change
| expect( | |
| page | |
| .getByRole( 'heading', { | |
| name: 'Disputes', | |
| } ) | |
| .nth( 1 ) | |
| ).toBeVisible(); | |
| expect( | |
| page.getByRole( 'heading', { name: 'Disputes' } ).nth( 1 ) | |
| ).toBeVisible(); |
There was a problem hiding this comment.
Thank you for the suggestion, applied in 3d48cdf
Comment on lines
21
to
23
| await page | ||
| .locator( '.woocommerce-table__table.is-loading' ) | ||
| .waitFor( { state: 'hidden' } ); |
There was a problem hiding this comment.
Nitpick: The .waitFor() works great, but the { state: 'hidden' } makes it less obvious. Another alternative would be to change it to expect().toHaveCount().
Suggested change
| await page | |
| .locator( '.woocommerce-table__table.is-loading' ) | |
| .waitFor( { state: 'hidden' } ); | |
| await expect( | |
| page.locator( '.woocommerce-table__table.is-loading' ) | |
| ).toHaveCount( 0 ); |
There was a problem hiding this comment.
Agreed, this is more clear to define what is expected of the test. Updated in 3d48cdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9959
Changes proposed in this Pull Request
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge