Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GlobalStep] Total Amounts are not displayed in an Explicit format on pages with Cart and Checkout blocks. #2648

Closed
1 of 3 tasks
gglobalstep opened this issue Aug 3, 2021 · 7 comments · Fixed by #8636
Closed
1 of 3 tasks
Assignees
Labels
focus: multi-currency priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@gglobalstep
Copy link

gglobalstep commented Aug 3, 2021

Bug Description:

Total Amounts are not displayed in an Explicit format on pages with Cart and Checkout blocks.

Environment:

Woocommerce Version : WooCommerce 5.5.2
WooCommerce Payments - 2.8.0-rc3.

PC:
Windows 10, Mac 10.14.6
Chrome(Version 91.0.4472.77)
Firefox(Version 88.0)
Safari: v14.1.2

Steps To Reproduce:

  1. Create any test site using JN site.
  2. Install and activate all the required plugins.
  3. Upload and activate the WooCommerce Payments v2.8.0-rc3 plugin.
  4. Complete the setup wizard.
  5. Complete the KYC flow.
  6. Install and activate WooCommerce Blocks plugin.
  7. Create a page with Cart and Checkout blocks.
  8. As a shopper add a product to the cart.
  9. Visit to Cart and checkout blocks pages.
  10. Observe that Total Amounts are not displayed in an Explicit format.

Actual Result:

Total Amounts are not displayed in an Explicit format on pages with Cart and Checkout blocks.

Expected Result:

Total Amounts should be displayed in an Explicit format on pages with Cart and Checkout blocks.

Screenshot:

#2648_1
#2648

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.

`

WordPress Environment

WC Version: 5.5.2
REST API Version: ✔ 5.5.2
WC Blocks Version: ✔ 5.6.0
Action Scheduler Version: ✔ 3.2.1
WC Admin Version: ✔ 2.4.4
Log Directory Writable: ✔
WP Version: 5.8
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
External object cache: –

Server Environment

Server Info: Apache/2.4.48 (Unix) OpenSSL/1.0.2g
PHP Version: 7.4.21
PHP Post Max Size: 1 GB
PHP Time Limit: 30
PHP Max Input Vars: 5000
cURL Version: 7.47.0
OpenSSL/1.0.2g

SUHOSIN Installed: –
MySQL Version: 5.7.33-0ubuntu0.16.04.1-log
Max Upload Size: 512 MB
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
GZip: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Database

WC Database Version: 5.5.2
WC Database Prefix: wp_
Total Database Size: 5.44MB
Database Data Size: 3.82MB
Database Index Size: 1.62MB
wp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_order_itemmeta: Data: 0.06MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_actions: Data: 0.08MB + Index: 0.13MB + Engine InnoDB
wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_logs: Data: 0.06MB + Index: 0.03MB + Engine InnoDB
wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_comments: Data: 0.06MB + Index: 0.09MB + Engine InnoDB
wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_ms_snippets: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_options: Data: 2.48MB + Index: 0.08MB + Engine InnoDB
wp_postmeta: Data: 0.23MB + Index: 0.20MB + Engine InnoDB
wp_posts: Data: 0.06MB + Index: 0.06MB + Engine InnoDB
wp_snippets: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB
wp_wc_admin_notes: Data: 0.05MB + Index: 0.00MB + Engine InnoDB
wp_wc_admin_note_actions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB
wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB
wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB

Post Type Counts

attachment: 24
page: 8
post: 2
product: 22
product_variation: 7
revision: 3
shipping_package: 2
shop_order: 28
shop_order_refund: 3
shop_subscription: 4

Security

Secure connection (HTTPS): ✔
Hide errors from visitors: ✔

Active Plugins (8)

Query Monitor: by John Blackbourn – 3.7.1
Code Snippets: by Code Snippets Pro – 2.14.1
Companion Plugin: by Osk – 1.18
WooCommerce Blocks: by Automattic – 5.6.0
WooCommerce Advanced Shipping Packages: by Jeroen Sormani – 1.1.8
WooCommerce Payments: by Automattic – 2.8.0-rc
WooCommerce Subscriptions: by WooCommerce – 3.1.3
WooCommerce: by Automattic – 5.5.2

Inactive Plugins (6)

Akismet Anti-Spam: by Automattic – 4.1.10
Google Listings and Ads: by WooCommerce – 1.3.0
Hello Dolly: by Matt Mullenweg – 1.7.2
Jetpack: by Automattic – 9.9.1
Mailchimp for WooCommerce: by Mailchimp – 2.5.1
MailPoet 3 (New): by MailPoet – 3.65.1

Dropin Plugins (1)

db.php: Query Monitor Database Class

Settings

API Enabled: –
Force SSL: –
Currency: USD ($)
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Number of Decimals: 2
Taxonomies: Product Types: external (external)
grouped (grouped)
simple (simple)
subscription (subscription)
variable (variable)
variable subscription (variable-subscription)

Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog)
exclude-from-search (exclude-from-search)
featured (featured)
outofstock (outofstock)
rated-1 (rated-1)
rated-2 (rated-2)
rated-3 (rated-3)
rated-4 (rated-4)
rated-5 (rated-5)

Connected to WooCommerce.com: –

WC Pages

Shop base: #5 - /shop/
Cart: #6 - /cart/
Checkout: #7 - /checkout/
My account: #8 - /my-account/
Terms and conditions: ❌ Page not set

Theme

Name: Storefront
Version: 3.7.0
Author URL: https://woocommerce.com/
Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme
WooCommerce Support: ✔

Templates

Overrides: –

Subscriptions

WCS_DEBUG: ✔ No
Subscriptions Mode: ✔ Live
Subscriptions Live URL: https://sensible-snow.jurassic.ninja
Subscription Statuses: wc-active: 4
WooCommerce Account Connected: ❌ No
Report Cache Enabled: ✔ Yes
Cache Update Failures: ✔ 0 failure

Store Setup

Country / State: United States (US) — California

Subscriptions by Payment Gateway

WooCommerce Payments: wc-active: 4

Payment Gateway Support

WooCommerce Payments: products
refunds
subscriptions
subscription_cancellation
subscription_suspension
subscription_reactivation
subscription_amount_changes
subscription_date_changes
subscription_payment_method_change
subscription_payment_method_change_customer
subscription_payment_method_change_admin
multiple_subscriptions
tokenization
add_payment_method

Action Scheduler

Complete: 164
Oldest: 2021-08-03 10:59:32 +0000
Newest: 2021-08-03 15:24:05 +0000

Failed: 1
Oldest: –
Newest: –

Pending: 8
Oldest: 2021-08-04 13:25:31 +0000
Newest: 2021-11-01 11:51:41 +0000

Status report information

Generated at: 2021-08-03 15:24:08 +00:00
`

@tpaksu tpaksu added the component: customer multi-currency Issues related to customer multi-currency project label Aug 4, 2021
@dwainm dwainm added the type: bug The issue is a confirmed bug. label Sep 7, 2021
@tpaksu tpaksu self-assigned this Sep 8, 2021
@tpaksu tpaksu added the status: has pr The issue has a PR. label Sep 8, 2021
@tpaksu tpaksu removed their assignment Sep 8, 2021
@tpaksu tpaksu removed the status: has pr The issue has a PR. label Sep 8, 2021
@tpaksu tpaksu self-assigned this Sep 16, 2021
@tpaksu tpaksu added the status: has pr The issue has a PR. label Sep 16, 2021
@tpaksu
Copy link
Contributor

tpaksu commented Nov 15, 2021

This issue has been discussed with different teams, and different ways of modifying values from outside the plugin has been proposed, It's still being discussed what the method should be used in WCPay to alter a place in Gutenberg Blocks plugin block. The previous attempts of the fixes were all not backwards compatible, or had security concerns. This issue will get updates after a decision is made and the solution is ready to ship.

@daquinons daquinons added the status: on hold The issue is currently not prioritized. label Dec 20, 2021
@tpaksu tpaksu removed their assignment Jan 17, 2022
@tpaksu tpaksu removed status: has pr The issue has a PR. status: on hold The issue is currently not prioritized. labels Jan 17, 2022
@tpaksu
Copy link
Contributor

tpaksu commented Jan 17, 2022

Closed the related PR's because it may be better handled by team Rubik, because they are more capable of their repository and will know how to proceed.

@pierorocca pierorocca added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Jan 18, 2024
@bborman22
Copy link
Contributor

As we're getting caught up on some of the existing multi-currency issues, I confirmed that this issue is still present and has a lot of background and existing discussion. Some of the most relevant discussion is in this woocommerce/woocommerce-blocks#4756 PR. While I was in there I just wanted to look into where this is handled on the shortcode side and found that WC_Payments_Explicit_Price_Formatter is handling this with the woocommerce_cart_total filter. Just noting this here so that when this work comes around we have some additional context.

@pierorocca pierorocca removed the component: customer multi-currency Issues related to customer multi-currency project label Mar 13, 2024
@reykjalin reykjalin self-assigned this Apr 10, 2024
@reykjalin
Copy link
Contributor

reykjalin commented Apr 10, 2024

The CurrencyFormatter available in the Blocks REST extension interface seems like the right place to start here.

@reykjalin
Copy link
Contributor

It's also possible that the totalValue Total Footer Item filter is sufficient. It may be necessary to also use the CurrencyFormatter interface to modify the Store API currency response, but this filter alone should be a good start.

@bborman22
Copy link
Contributor

Please add your planning poker estimate with Zenhub @reykjalin

@reykjalin
Copy link
Contributor

reykjalin commented Apr 13, 2024

Turns out the totalValue filter is being released with WC version 8.8, so this is pretty fortuitous timing 🙂

We can add the filter without breaking any functionality in WC 8.6 and 8.7 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment