Skip to content

Commit

Permalink
tweak emoji survey prompt - "these", was "those" (#8725)
Browse files Browse the repository at this point in the history
Co-authored-by: Rua Haszard <[email protected]>
Co-authored-by: Eric Jinks <[email protected]>
  • Loading branch information
3 people authored Apr 29, 2024
1 parent 3c6bba1 commit ebee3fe
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 7 deletions.
5 changes: 5 additions & 0 deletions changelog/fix-8724-are-these-metrics
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Significance: patch
Type: fix
Comment: This is covered by emoji survey changelog from #8506


2 changes: 1 addition & 1 deletion client/components/payment-activity/survey/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const Survey: React.FC = () => {
<div className="wcpay-payments-activity__survey">
<div className="survey_container">
{ __(
'Are those metrics helpful?',
'Are these metrics helpful?',
'woocommerce-payments'
) }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`WcPayOverviewSurveyContextProvider test survey initial display 1`] = `
<div
class="survey_container"
>
Are those metrics helpful?
Are these metrics helpful?
<div
class="survey_container__emoticons"
>
Expand Down Expand Up @@ -92,7 +92,7 @@ exports[`WcPayOverviewSurveyContextProvider test survey with comments textbox 1`
<div
class="survey_container"
>
Are those metrics helpful?
Are these metrics helpful?
<div
class="survey_container__emoticons"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe( 'WcPayOverviewSurveyContextProvider', () => {
</WcPayOverviewSurveyContextProvider>
);

const surveyText = screen.getByText( 'Are those metrics helpful?' );
const surveyText = screen.getByText( 'Are these metrics helpful?' );
expect( surveyText ).toBeInTheDocument();

const buttons = screen.getAllByRole( 'button' );
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ exports[`PaymentActivity component should render 1`] = `
<div
class="survey_container"
>
Are those metrics helpful?
Are these metrics helpful?
<div
class="survey_container__emoticons"
>
Expand Down
4 changes: 2 additions & 2 deletions client/components/payment-activity/test/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ describe( 'PaymentActivity component', () => {
const { container, getByText } = render( <PaymentActivity /> );

// Check survey is rendered.
getByText( 'Are those metrics helpful?' );
getByText( 'Are these metrics helpful?' );

expect( container ).toMatchSnapshot();
} );
Expand All @@ -140,7 +140,7 @@ describe( 'PaymentActivity component', () => {
const { queryByText } = render( <PaymentActivity /> );

expect(
queryByText( 'Are those metrics helpful?' )
queryByText( 'Are these metrics helpful?' )
).not.toBeInTheDocument();
} );
} );

0 comments on commit ebee3fe

Please sign in to comment.