Merge branch 'develop' into fix/woopay-theming-border-styles

Automattic · Oct 15, 2024 · cff7707 · cff7707
2 parents 6495f0d + 3a0ed10
commit cff7707
Show file tree

Hide file tree

Showing 88 changed files with 593 additions and 256 deletions.
diff --git a/.github/actions/e2e/env-setup/action.yml b/.github/actions/e2e/env-setup/action.yml
@@ -66,7 +66,7 @@ runs:
       shell: bash
       run : |
         echo "::group::Kill webserver running on port 8084"
-        sudo fuser -k -n tcp 8084
+        sudo fuser -k -n tcp 8084 || true
         echo "::endgroup::"
 
     # Prepare test environment

diff --git a/bin/run-ci-tests-check-coverage.bash b/bin/run-ci-tests-check-coverage.bash
@@ -17,6 +17,11 @@ else
 fi
 
 composer self-update && composer install --no-progress
+# SVN is needed when installing WP.
+if ! [ -x "$(command -v svn)" ]; then
+	echo 'Installing SVN...'
+	sudo apt-get install -y subversion
+fi
 sudo systemctl start mysql.service
 bash bin/install-wp-tests.sh woocommerce_test root root localhost $WP_VERSION $WC_VERSION false
 echo 'Running the tests...'

diff --git a/bin/run-ci-tests.bash b/bin/run-ci-tests.bash
@@ -10,6 +10,13 @@ WCPAY_DIR="$GITHUB_WORKSPACE"
 echo 'Updating composer version & Install dependencies...'
 composer self-update && composer install --no-progress
 
+# SVN is needed when installing WP.
+if ! [ -x "$(command -v svn)" ]; then
+	echo 'Installing SVN...'
+	sudo apt-get install -y subversion
+fi
+
+# SVN is needed when installing WP.
 echo 'Starting MySQL service...'
 sudo systemctl start mysql.service
 

diff --git a/changelog.txt b/changelog.txt
@@ -1,5 +1,37 @@
 *** WooPayments Changelog ***
 
+= 8.3.0 - 2024-10-03 =
+* Add - Add compatibility with the buttonAttributes API from Woo Blocks
+* Add - Add rate limiter to compatibility data updates
+* Add - Add UTC to the date time column header of transactions list page.
+* Add - Disable save changes button until a setting has changed.
+* Add - Enables Klarna with amount limitations for FR country code.
+* Add - Provide locale to Express Checkout Element.
+* Add - Redesigned the Payment Method labels for the Blocks Checkout
+* Add - Show a notice in Payments > Settings > Deposits if there is an error with the bank account.
+* Add - Updates to the Embedded KYC to ensure compatibility with Progressive Onboarding
+* Fix - Allow the network saved card payment method setting to be overridden by the `wcpay_force_network_saved_cards` filter
+* Fix - Create div container element with JS dynamically.
+* Fix - Do not display BNPL methods and PMME when WooPayments is disabled
+* Fix - Fixed CC form input fields appearance when using RGBA
+* Fix - Fixed invalid appearance warnings
+* Fix - Fix event prefix duplication in Tracks events
+* Fix - Handle loadError in ECE for Block Context Initialization.
+* Fix - Prevent failures and notices related to trying to schedule AS jobs before init.
+* Fix - Prevent multi-currency conversion during a REST API request.
+* Fix - Remove text color from WooPay component.
+* Fix - Rendering Test Model badge only for Credit Card
+* Fix - Sync phone changes with WooPay phone field.
+* Fix - Update payment methods when manual capture is enabled.
+* Update - Default express checkout button label to "Only icon".
+* Update - Remove feature flag to make embedded KYC enabled by default
+* Update - Some minor styling updates on the Onboarding form.
+* Update - Update express payment methods with a title, description and gatewayId
+* Dev - fix: prevent multiple instances of WC_Payments_Apple_Pay_Registration
+* Dev - Fix gutenberg blueberry focus color
+* Dev - Fix progressive onboarding e2e test
+* Dev - Some refactors to embedded KYC logic.
+
 = 8.2.2 - 2024-09-24 =
 * Fix - Fix WooPay pre-checking place order bug when buying a subscription.
 

diff --git a/changelog/9363-manual-capture-disable-payment-methods b/changelog/9363-manual-capture-disable-payment-methods
diff --git a/changelog/add-8522-utc-list-page-csv b/changelog/add-8522-utc-list-page-csv
diff --git a/changelog/add-9245-ece-locale b/changelog/add-9245-ece-locale
diff --git a/changelog/add-9462-add-fr-to-klarna-country-list b/changelog/add-9462-add-fr-to-klarna-country-list
diff --git a/changelog/add-express-payment-button-styles b/changelog/add-express-payment-button-styles
diff --git a/changelog/add-server-6156-compatibility-data-rate-limiter b/changelog/add-server-6156-compatibility-data-rate-limiter
diff --git a/changelog/add-stripe-floating-labels b/changelog/add-stripe-floating-labels
@@ -0,0 +1,4 @@
+Significance: minor
+Type: add
+
+Using Floating Labels with Stripe Appearance API for Blocks Checkout
diff --git a/changelog/add-support-for-woo-button-controls b/changelog/add-support-for-woo-button-controls
@@ -0,0 +1,4 @@
+Significance: minor
+Type: update
+
+Add support for the style controls for the WooPay button
diff --git a/changelog/add-test-mode-badge-classic-checkout b/changelog/add-test-mode-badge-classic-checkout
@@ -0,0 +1,4 @@
+Significance: minor
+Type: add
+
+Add test mode badge to classic checkout and add payment method.
diff --git a/changelog/as-fix-react-error-container-not-found b/changelog/as-fix-react-error-container-not-found
diff --git a/changelog/as-fix-unnecessary-css-import b/changelog/as-fix-unnecessary-css-import
@@ -0,0 +1,4 @@
+Significance: minor
+Type: fix
+
+Stop enqueuing woopay-express-button.css to prevent 404 errors
diff --git a/changelog/blocks-checkout-label-design b/changelog/blocks-checkout-label-design
diff --git a/changelog/chore-v8.3.0-wc-version-bump b/changelog/chore-v8.3.0-wc-version-bump
diff --git a/changelog/dev-9393-embedded-kyc-po b/changelog/dev-9393-embedded-kyc-po
diff --git a/changelog/dev-bump-wc-tested-up-to-version b/changelog/dev-bump-wc-tested-up-to-version
@@ -0,0 +1,4 @@
+Significance: patch
+Type: dev
+
+Bump WC tested up to version to 9.3.3.
diff --git a/changelog/dev-fix-po-test b/changelog/dev-fix-po-test
diff --git a/changelog/dev-i4-design-updates b/changelog/dev-i4-design-updates
diff --git a/changelog/dev-improve-unit-tests-handling-of-filters b/changelog/dev-improve-unit-tests-handling-of-filters
diff --git a/changelog/dev-remove-feature-flag b/changelog/dev-remove-feature-flag
diff --git a/changelog/dev-session-fixes b/changelog/dev-session-fixes
diff --git a/changelog/dev-update-dockerfile-to-allow-more-xdebug-config b/changelog/dev-update-dockerfile-to-allow-more-xdebug-config
diff --git a/changelog/e2e-migrate-dispute-challenge-accept-flows-to-playwright b/changelog/e2e-migrate-dispute-challenge-accept-flows-to-playwright
diff --git a/changelog/fix-8331-bank-error-notice-settings-deposit b/changelog/fix-8331-bank-error-notice-settings-deposit
diff --git a/changelog/fix-9142-classname-optional-default-null b/changelog/fix-9142-classname-optional-default-null
@@ -0,0 +1,4 @@
+Significance: patch
+Type: dev
+
+Migrate WizardTaskItem and CollapsibleBody components to TypeScript, making the className prop optional.
diff --git a/changelog/fix-9181-unintended-mccy-conversion-during-rest-api-request b/changelog/fix-9181-unintended-mccy-conversion-during-rest-api-request
diff --git a/changelog/fix-9332-default-express-buttons-only-icon b/changelog/fix-9332-default-express-buttons-only-icon
diff --git a/changelog/fix-9384-invalid-appearence b/changelog/fix-9384-invalid-appearence
diff --git a/changelog/fix-9390-hide-bnpl-pmme-if-gateway-is-disabled b/changelog/fix-9390-hide-bnpl-pmme-if-gateway-is-disabled
diff --git a/changelog/fix-9414-unhandled-ece-loaderror b/changelog/fix-9414-unhandled-ece-loaderror
diff --git a/changelog/fix-9434-action-scheduler-service-schedule-job-init b/changelog/fix-9434-action-scheduler-service-schedule-job-init
diff --git a/changelog/fix-9548-woopay-auto-enable b/changelog/fix-9548-woopay-auto-enable
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Auto-enabled WooPay for new accounts.
diff --git a/changelog/fix-add-svn-script b/changelog/fix-add-svn-script
@@ -0,0 +1,5 @@
+Significance: patch
+Type: dev
+Comment: fix: add GH action SVN dependency
+
+
diff --git a/changelog/fix-convert-rgba-text-color b/changelog/fix-convert-rgba-text-color
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Converting text color rgba to hex to prevent Stripe warning
diff --git a/changelog/fix-dark-mode-stripe-appearance b/changelog/fix-dark-mode-stripe-appearance
diff --git a/changelog/fix-e2e-save-settings-button-disabled b/changelog/fix-e2e-save-settings-button-disabled
@@ -0,0 +1,5 @@
+Significance: patch
+Type: dev
+Comment: fix: e2e tests w/ save settings button disabled.
+
+
diff --git a/changelog/fix-multiple-instances-of-wc-payments-in-tests b/changelog/fix-multiple-instances-of-wc-payments-in-tests
@@ -0,0 +1,4 @@
+Significance: patch
+Type: dev
+
+fix: prevent multiple instances of WC_Payments_Apple_Pay_Registration
diff --git a/changelog/fix-reintroduce-support-for-wcpay_force_network_saved_cards-filter b/changelog/fix-reintroduce-support-for-wcpay_force_network_saved_cards-filter
diff --git a/changelog/fix-remove-text-color-from-woopay-component b/changelog/fix-remove-text-color-from-woopay-component
diff --git a/changelog/fix-sync-woopay-phone-field b/changelog/fix-sync-woopay-phone-field
diff --git a/changelog/fix-test-mode-badge-credit-card b/changelog/fix-test-mode-badge-credit-card
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Rendering Test Model badge only for Credit Card
diff --git a/changelog/fix-tracks-event-prefix-duplication b/changelog/fix-tracks-event-prefix-duplication
diff --git a/changelog/fix-update-dark-blueberry-color b/changelog/fix-update-dark-blueberry-color
diff --git a/changelog/fix-woopay-pre-checking-save-my-info-place-order b/changelog/fix-woopay-pre-checking-save-my-info-place-order
diff --git a/changelog/fix-wrong-utils-path b/changelog/fix-wrong-utils-path
@@ -0,0 +1,4 @@
+Significance: patch
+Type: dev
+
+Fixed wrong utils path that would prevent checkout with WooPay OTP
diff --git a/changelog/revert-9439-multi-currency-v2 b/changelog/revert-9439-multi-currency-v2
diff --git a/changelog/update-9305-settings-disable-save-changes-button b/changelog/update-9305-settings-disable-save-changes-button
diff --git a/changelog/update-9401-woopayments-incentive-to-payments-task-tracks-props b/changelog/update-9401-woopayments-incentive-to-payments-task-tracks-props
diff --git a/changelog/update-9540-payment-task-onboarding-flow b/changelog/update-9540-payment-task-onboarding-flow
@@ -0,0 +1,4 @@
+Significance: patch
+Type: update
+
+Payments task onboarding flows skip the Connect page.
diff --git a/changelog/update-express-method-titles b/changelog/update-express-method-titles
diff --git a/...-methods-setup/wizard/collapsible-body.js → ...methods-setup/wizard/collapsible-body.tsx b/...-methods-setup/wizard/collapsible-body.js → ...methods-setup/wizard/collapsible-body.tsx
@@ -10,7 +10,10 @@ import classNames from 'classnames';
 import WizardTaskContext from './task/context';
 import './collapsible-body.scss';
 
-const CollapsibleBody = ( { className, ...restProps } ) => {
+const CollapsibleBody: React.FC< React.HTMLAttributes< HTMLDivElement > > = ( {
+	className,
+	...restProps
+} ) => {
 	const { isActive } = useContext( WizardTaskContext );
 
 	return (

diff --git a/...itional-methods-setup/wizard/task-item.js → ...tional-methods-setup/wizard/task-item.tsx b/...itional-methods-setup/wizard/task-item.js → ...tional-methods-setup/wizard/task-item.tsx
@@ -11,7 +11,19 @@ import { Icon, check } from '@wordpress/icons';
 import WizardTaskContext from './task/context';
 import './task-item.scss';
 
-const WizardTaskItem = ( { children, title, index, className } ) => {
+interface WizardTaskItemProps {
+	children: React.ReactNode;
+	title: string;
+	index: number;
+	className?: string;
+}
+
+const WizardTaskItem: React.FC< WizardTaskItemProps > = ( {
+	children,
+	title,
+	index,
+	className,
+} ) => {
 	const { isCompleted, isActive } = useContext( WizardTaskContext );
 
 	return (
@@ -26,7 +38,7 @@ const WizardTaskItem = ( { children, title, index, className } ) => {
 				className="wcpay-wizard-task__headline"
 				// tabindex with value `-1` is necessary to programmatically set the focus
 				// on an element that is not interactive.
-				tabIndex="-1"
+				tabIndex={ -1 }
 			>
 				<div className="wcpay-wizard-task__icon-wrapper">
 					<div className="wcpay-wizard-task__icon-text">

diff --git a/client/checkout/api/test/index.test.js b/client/checkout/api/test/index.test.js
@@ -51,6 +51,7 @@ const mockAppearance = {
 		fontFamily: undefined,
 		fontSizeBase: undefined,
 	},
+	labels: 'above',
 };
 
 describe( 'WCPayAPI', () => {

diff --git a/client/checkout/blocks/payment-elements.js b/client/checkout/blocks/payment-elements.js
@@ -36,7 +36,7 @@ const PaymentElements = ( { api, ...props } ) => {
 	useEffect( () => {
 		async function generateUPEAppearance() {
 			// Generate UPE input styles.
-			let upeAppearance = getAppearance( 'blocks_checkout' );
+			let upeAppearance = getAppearance( 'blocks_checkout', false, true );
 			upeAppearance = await api.saveUPEAppearance(
 				upeAppearance,
 				'blocks_checkout'