is_woopay_preflight_check - change from empty to isset

Automattic · Aug 26, 2023 · 13e49c3 · 13e49c3
1 parent 1f7b895
commit 13e49c3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Internal/Payment/PaymentRequest.php b/src/Internal/Payment/PaymentRequest.php
@@ -45,7 +45,7 @@ public function get_fraud_prevention_token(): ?string {
 	 * @return bool
 	 */
 	public function is_woopay_preflight_check(): bool {
-		return ! empty( $this->request['is-woopay-preflight-check'] );
+		return isset( $this->request['is-woopay-preflight-check'] );
 	}
 
 	/**

diff --git a/tests/unit/src/Internal/Payment/PaymentRequestTest.php b/tests/unit/src/Internal/Payment/PaymentRequestTest.php
@@ -86,7 +86,7 @@ public function provider_text_string_for_bool_representation(): array {
 			],
 			'empty string'     => [
 				'value'    => '',
-				'expected' => false,
+				'expected' => true,
 			],
 			'any string'       => [
 				'value'    => 'any string',