Switch to WordPress-VIP-Go standards #1050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to checkout the correct repo here: https://github.com/Automattic/vip-go-mu-plugins/blob/master/Makefile#L16 |
And use those with phpcs
mjangda
force-pushed
the
update/phpcs-WordPress-VIP-Go
branch
from
a00a1d3
to
909b658
Compare
4 tasks
Since there are still many errors we need to work through.
GaryJones
reviewed
Jan 9, 2019
| @@ -13,20 +13,20 @@ phpunit: | |||
| phpdoc: | |||
| phpdoc run --no-interaction | |||
|
|
|||
| phpcs: | |||
| initphpcs: | |||
| test -f /tmp/phpcs || curl -L https://squizlabs.github.io/PHP_CodeSniffer/phpcs.phar -o /tmp/phpcs && chmod +x /tmp/phpcs | |||
| test -d /tmp/wpcs || git clone -b master --depth 1 https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards.git /tmp/wpcs | |||
There was a problem hiding this comment.
WPCS master and VIPCS master are not yet compatible.
The safest option for now, is to checkout the 1.2.1 tag of WPCS, and the 0.4.0 tag of VIPCS.
I'll make it clear in VIP when a release of VIPCS is compatible with WPCS master.
There was a problem hiding this comment.
VIPCS 2.0 has been released, and it is compatible with WPCS 2.1+.
|
This was done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1032