Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set shivammathur/setup-php to fixed version #363

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Jun 12, 2023

Latest version of shivammathur/setup-php has some problems with PHPUnit setup (404 errors). Switch to a fixed version and use 2.25.2.

TODO:

  • Switch to version 2.25.2 of shivammathur/setup-php
  • [N/A] Add/update tests -- unit and/or integrated (if needed)
  • [N/A] Add to, or update, Scan run detail report as applicable
  • Check status of automated tests
  • [N/A] Ensure PHPDoc comments are up to date for functions added or altered
  • Assign appropriate priority and type of change labels.
  • Changelog entry (for VIP) [ Changelog for version 1.3.5 #359 ]

Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved pull request #363 as it contains only auto-approvable files -- non-functional changes to PHP files or file-types that are auto-approvable (css, csv, eot, gif, gz, ico, ini, jpeg, jpg, json, less, map, md, mdown, mo, mp4, otf, pcss, pdf, po, pot, png, sass, scss, styl, ttf, txt, woff, woff2, yml).

@gudmdharalds gudmdharalds merged commit 0b02054 into trunk Jun 12, 2023
@gudmdharalds gudmdharalds deleted the update/shivammathur-fixed-version branch June 12, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants