-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce custom file extensions with scanners #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis identified issues
VIP Code Analysis Bot has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 1 error
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Scan run detail
Software versions
Options file (
|
PHP lint optionsPHP lint files enabled:
Lint modified files only:
Directories not PHP linted:
SVG configurationSVG scanning enabled:
Auto-approval configurationAuto-approvals enabled:
Non-functional changes auto-approved:
Auto-approved file-types:
|
PHPCS configurationPHPCS scanning enabled:
PHPCS severity level:
Standard(s) used:
Runtime set:
Custom sniffs included:
Custom sniffs excluded:
Directories not PHPCS scanned:
WPScan API configurationWPScan API scanning enabled:
|
Dismissing review as all inline comments are obsolete by now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis identified issues
VIP Code Analysis Bot has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 1 error
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Scan run detail
Software versions
Options file (
|
PHP lint optionsPHP lint files enabled:
Lint modified files only:
Directories not PHP linted:
SVG configurationSVG scanning enabled:
Auto-approval configurationAuto-approvals enabled:
Non-functional changes auto-approved:
Auto-approved file-types:
|
PHPCS configurationPHPCS scanning enabled:
PHPCS severity level:
Standard(s) used:
Runtime set:
Custom sniffs included:
Custom sniffs excluded:
Directories not PHPCS scanned:
WPScan API configurationWPScan API scanning enabled:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis identified issues
VIP Code Analysis Bot has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 1 error
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Scan run detail
Software versions
Options file (
|
PHP lint optionsPHP lint files enabled:
Lint modified files only:
Directories not PHP linted:
SVG configurationSVG scanning enabled:
Auto-approval configurationAuto-approvals enabled:
Non-functional changes auto-approved:
Auto-approved file-types:
|
PHPCS configurationPHPCS scanning enabled:
PHPCS severity level:
Standard(s) used:
Runtime set:
Custom sniffs included:
Custom sniffs excluded:
Directories not PHPCS scanned:
WPScan API configurationWPScan API scanning enabled:
|
…False() with assertStringContainsString()
…False() with assertStringContainsString()
…False() with assertStringContainsString()
…False() with assertStringContainsString()
…False() with assertStringContainsString()
No issues were found to report when scanning latest commit (commit-ID: e80b43a) This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation. Scan run detail
|
This pull request introduces support for configuring custom file extensions for different scanners.
This resolves #188.
TODO:
--autoapprove-php-nonfunctional-changes-file-extensions
--lint-file-extensions
--svg-file-extensions
--phpcs-file-extensions
--wpscan-plugin-api-file-extensions
--wpscan-theme-api-file-extensions
--help
messagevipgoci_option_array_handle()
function so that it can use array as a list of forbidden values as well as a string.Scan run detail
report as applicabletests/unit/MainRunInitOptionsWpscanTest.php
tests/unit/MainRunInitOptionsLintTest.php
tests/unit/MainRunInitOptionsAutoapproveTest.php
tests/unit/OptionsArrayHandleTest.php
tests/integration/ApNonfunctionalChangesTest.php
tests/integration/ApSvgFilesTest.php
tests/integration/LintScanCommitTest.php
tests/integration/PhpcsScanScanCommitTest.php
tests/integration/SvgScanScanCommitTest.php
tests/integration/WpCoreMiscGetAddonDataAndSlugsForDirectoryTest.php
tests/integration/WpCoreMiscScanDirectoryForAdddonsTest.php
tests/integration/MainRunInitOptionsSvgTest.php
tests/integration/MainRunInitOptionsPhpcsTest.php
tests/integration/SvgScanScanSingleFileTest.php
tests/unit/ReportCreateScanDetailsAutoApproveConfigurationTest.php
tests/unit/ReportCreateScanDetailsPhpLintOptionsTest.php
tests/unit/ReportCreateScanDetailsPhpcsConfigurationTest.php
tests/unit/ReportCreateScanDetailsSvgConfigurationTest.php
tests/unit/ReportCreateScanDetailsWpscanConfigurationTest.php
PHPDoc
comments are up to date for functions added or altered