Update logging & memory management, retry certain HTTP requests, catch out of memory situations #258

gudmdharalds · 2022-03-08T14:39:14Z

This pull request brings in updates in a number of areas, such as logging, garbage collection and retrying certain HTTP requests.

TODO:

…al of whitespacing elsewhere.

…" with "pull-request."

wpcomvip-vipgoci-bot

phpcs scanning turned up:

🚫 1 error

⚠️ 5 warnings

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.1` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime for linting: PHP 8.1: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

auto-approval.php

github-api.php

wpcomvip-vipgoci-bot

phpcs scanning turned up:

🚫 1 error

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.1` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime for linting: PHP 8.1: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

github-api.php

Dismissing review as all inline comments are obsolete by now

wpcomvip-vipgoci-bot · 2022-03-08T18:31:49Z

No issues were found to report when scanning latest commit (commit-ID: d2e5340)

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.1` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime for linting: PHP 8.1: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

gudmdharalds added 11 commits March 8, 2022 13:22

Move garbage collection to main.php, set memory limit, log URLs to PRs.

143eb35

Rename class to match file

c7640e8

Encoding message logged for more safety, updating tests accordingly.

1f23d1b

SVG PHP runtime version displayed in scan-details.

ed34df9

Log when PHP version is determined.

b203446

Garbage collection moved to main.php, stop logging auto-approvals.

c9bc198

Adding log message when starting linting.

9fb2d6c

Adding logging, garbage collection has moved to main.php, moved remov…

cf746bd

…al of whitespacing elsewhere.

Add function to output URLs to PRs, change usage in main.php

b79b7cf

Fixing whitespacing, adding phpcs:ignore

8be58b2

Adding test for vipgoci_github_prs_urls_get()

d1ec535

gudmdharalds added the [Type] Enhancement label Mar 8, 2022

gudmdharalds added this to the 1.2.2 milestone Mar 8, 2022

gudmdharalds self-assigned this Mar 8, 2022

gudmdharalds added 16 commits March 8, 2022 14:45

Adding linebreak, previously removed by the function, but not any more.

2d83484

Changing "Pull-Request" to "pull request".

cd254d4

Changing "Pull-Request" to "pull request".

1be6fd1

Changing "Pull-Request" to "pull request".

d359c95

Changing "Pull-Request" to "pull request".

7f8a16b

Changing "Pull-Request" to "pull request".

0ca09da

Changing "Pull-Request" to "pull request".

8d2a924

Changing "Pull-Request" to "pull request".

1fc798d

Changing "Pull-Request" to "pull request".

68067f8

Changing "Pull-Request" to "pull request".

d826164

Changing "Pull-Request" to "pull request".

1bd0063

Changing "Pull-Request" to "pull request".

93df850

Changing "Pull-Request" to "pull request".

1092a43

Retry mechanism for vipgoci_github_fetch_url(), replace "Pull-Request…

7298d05

…" with "pull-request."

Log to IRC when HTTP GET requests fail.

9e45315

Log to IRC when exiting due to HTTP GET failure.

819151f

wpcomvip-vipgoci-bot previously requested changes Mar 8, 2022

View reviewed changes

gudmdharalds added 3 commits March 8, 2022 15:32

Add comment explaining the purpose.

8528517

WP CS fix

0e4754c

WP CS fix

2d05a0a

wpcomvip-vipgoci-bot previously requested changes Mar 8, 2022

View reviewed changes

github-api.php Outdated Show resolved Hide resolved

Removing whitespace.

533b927

gudmdharalds added 6 commits March 8, 2022 15:49

Exit if temporary file name not found in PHPCS output.

b90b152

Providing exit code for vipgoci_sysexit()

4821278

Providing exit code for vipgoci_sysexit()

6f4e34b

Providing exit code for vipgoci_sysexit()

0713dbf

Log correct string for PHPCS version.

8119721

Define out of memory error.

f4cadfe

gudmdharalds changed the title ~~Various updates: Update logging, garbage collection to main.php, retry certain HTTP requests~~ Update logging & memory management, retry certain HTTP requests, catch out of memory situations Mar 8, 2022

gudmdharalds added 2 commits March 8, 2022 17:32

Handle out of memory situations.

8449953

Set maximum execution time for PHPCS.

d2e5340

gudmdharalds merged commit 0d8b219 into main Mar 8, 2022

gudmdharalds deleted the update-logging-and-other branch March 8, 2022 18:32

gudmdharalds added the [Pri] High label Mar 30, 2022

gudmdharalds mentioned this pull request Feb 9, 2023

Clean up test suites #244

Open

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update logging & memory management, retry certain HTTP requests, catch out of memory situations #258

Update logging & memory management, retry certain HTTP requests, catch out of memory situations #258

gudmdharalds commented Mar 8, 2022 •

edited

Loading

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot commented Mar 8, 2022

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

Update logging & memory management, retry certain HTTP requests, catch out of memory situations #258

Update logging & memory management, retry certain HTTP requests, catch out of memory situations #258

Conversation

gudmdharalds commented Mar 8, 2022 • edited Loading

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot commented Mar 8, 2022

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

gudmdharalds commented Mar 8, 2022 •

edited

Loading

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)