You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a PR to undo a change made to temporarily fix tests. At the time of writing, there is a file naming mismatch between WordPress' latest release and the latest version of the testing library pulled from tests/phpunit. This causes tests to fail, and can be fixed by specifying a release WordPress version.
Once WordPress 6.1 is released this should no longer be an issue. When that happens, ensure tests pass in this PR and merge.
See this discussion in this PR for details: #57 (comment).
@chriszarate This has been fixed in wp-env and tests are now fixed. I submitted a PR for this fix in WordPress/gutenberg#43020, but it ended up being fixed in a concurrent issue WordPress/gutenberg#42826 in a similar but more robust and better tested way. The original issue didn't yet exist when I first looked into solving this problem and unfortunately I was not aware of the overlap. Next time I'll run through issues a second time when I start actual development, especially when there's a fresh bug like that.
The WordPress version is now properly fixed to the phpunit version and we're good to unpin WordPress here.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to undo a change made to temporarily fix tests. At the time of writing, there is a file naming mismatch between WordPress' latest release and the latest version of the testing library pulled from
tests/phpunit. This causes tests to fail, and can be fixed by specifying a release WordPress version.Once WordPress 6.1 is released this should no longer be an issue. When that happens, ensure tests pass in this PR and merge.
See this discussion in this PR for details: #57 (comment).