Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.18.0 Prep #1105

Merged
merged 20 commits into from
Sep 16, 2022
Merged

2.18.0 Prep #1105

merged 20 commits into from
Sep 16, 2022

Conversation

luismulinari
Copy link
Contributor

@luismulinari luismulinari commented Sep 15, 2022 •
edited
Loading

Description

nickdaugherty and others added 19 commits September 2, 2022 11:35
@nickdaugherty
Do server-side logouts
37ba621
@nickdaugherty
Don't error for vip login
7380e89
@nickdaugherty
Merge branch 'develop' into update/server-side-logout
32ab06a
@pschoffer
[dev-env] Supports extended information table
c348faf
@pschoffer
add media redirect domain
9a03d6d
@pschoffer
lint
eb980f3
@mjangda
Don't pipe output through less
97b01f2 
This was originally meant to be useful but it's actually more
frustrating and a bit of an anti-pattern when working with a CLI tool.
It's especially frustrating because you can't easily disable the
behavior either. Plus, we're assuming that less or PAGER will be
available which may not always be the case.

Instead, let's just output via console.log and let the user decide
any additional piping they want to do.
@mjangda
Merge pull request #1097 from Automattic/update/remove-pager
3058842 
Don't pipe output through less
@pschoffer
Add @app.env to commands help
8e2f1f0
@pschoffer
jest
97c5e9f
@nickdaugherty
Merge pull request #1092 from Automattic/update/server-side-logout
b8787b1 
Improve login + logout
@pschoffer
Merge pull request #1099 from Automattic/update/add_at_notation_to_help
83191d7 
Add @app.env to commands help
@chriszarate
Add GitHub action to mark inactive issues and PRs as stale
c4f83b0
@mjangda
Merge pull request #1100 from Automattic/add/stale-issue-pr-bot
efa7a82 
Add GitHub action to mark inactive issues and PRs as stale
@pschoffer
Merge pull request #1096 from Automattic/add/extended_info
249b9ba 
[dev-env] Supports extended information table
@nickdaugherty
Remove http proxy support
b963a74 
HTTP is insecure and risks leaking access tokens and other sensitive data. We should not support a known insecure proxy configuration.
@nickdaugherty
Merge pull request #1102 from Automattic/remove/http-proxy-support
f629d3c 
Remove http proxy support
@luismulinari
Force the preference for WebSocket in case we see an error during con…
73423b1 
…nection (#1103)
@luismulinari
2.18.0 prep
a2ef323
@saroshaga
Copy link
Contributor

saroshaga commented Sep 15, 2022 •
edited
Loading

hi @luismulinari : can you please hold off on this for a bit? We need to release #1106 ASAP

Actually that's not fair to the other PRs. Sorry, please release if you have to.

@saroshaga
Using http module instead of already decommisioned API.apiFetch funct…
9960018 
…ion (#1106)

The apiFetch method of the API module was removed earlier but this reference was not updated: #1091
nickdaugherty
nickdaugherty approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@nickdaugherty nickdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luismulinari luismulinari merged commit a37bf44 into master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdaugherty nickdaugherty nickdaugherty approved these changes

@pschoffer pschoffer Awaiting requested review from pschoffer

@mjangda mjangda Awaiting requested review from mjangda

@jblz jblz Awaiting requested review from jblz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@luismulinari @saroshaga @nickdaugherty @pschoffer @mjangda @chriszarate