Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analytics tracking for non-vip sites #42

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

ingeniumed
Copy link
Contributor

Description

This will resolve #40 by turning off analytics tracking for non-vip sites. This way if you aren't on VIP there's no opt out to be done.

Follow up discussion is in the works to see if we can allow opt out/in for VIP sites as well. Getting this in first is important to ensure non vip sites don't have analytics being sent.

Steps to Test

  1. Check out PR.
  2. Spin up a wp-env and ensure nothing is sent
  3. Turn off the VIP sites check and set the keys to have -test at the end
  4. Spin up a vip dev-env with this and ensure stats are sent

@ingeniumed ingeniumed requested a review from a team as a code owner July 31, 2023 23:11
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alecgeatches alecgeatches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ingeniumed ingeniumed merged commit c01baee into trunk Jul 31, 2023
@ingeniumed ingeniumed deleted the remove/analytics-for-non-vip-sites branch July 31, 2023 23:20
@ingeniumed ingeniumed linked an issue Jul 31, 2023 that may be closed by this pull request
@alecgeatches alecgeatches mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy Analytics on by default for everybody and can't be turned off
2 participants