Adds Custom Color Controls to Customizer for Quadrat #3817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works fine in the customizer and the frontend but not on the editor, and we are also missing the new colors from the block options (they are showing the old palette) |
|
Still not convinced this is the right approach but now I believe that all of the bugs and notes noted have been resolved except for what is noted in the description. |
|
Yes, absolutely. It was a worthwhile experiment. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accomplishes the color customization of #3661
This uses the 'overwrite CSS variables' method to customize values.
These customizations are ONLY available in the Customizer.
The things to be customized are defined in the theme.json's 'custom_meta' block.
The 'Customizer Bridge' presents controls to the user based on that JSON and renders the stored values as Global Styles CSS variables.
The user DOES NOT have access to the selected colors via the block editor panel.