BCB: Add post comments styles #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the Gutenberg issue: WordPress/gutenberg#26864 I have added the button styling to the Reply link: |
|
Moved this to Gutenberg too: WordPress/gutenberg#26864 |
|
I removed some styles because of the PR to add some styles in Gutenberg. |
|
@jffng Shouldn't this be merged with https://github.com/Automattic/themes/tree/make/blank-canvas-blocks rather than trunk? |
|
I believe since we merged BCB to trunk, any changes to BCB can be made directly to trunk / synced to svn as soon as they're merged. |
jffng
force-pushed
the
add/post-comments-styles
branch
from
ad8a696 to
bdbc67a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts to address #3546.
Which of these styles do you think should live with Gutenberg?
Styling in Gutenberg a bit tricky because the post comments block relies on the Core comments template: https://github.com/WordPress/gutenberg/blob/9b75a5c44e934f580282e2d16cc462ff4567cded/packages/block-library/src/post-comments/index.php#L33