Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videomaker: Tighten up space between the H4 and paragraph on the homepage pattern. #4950

Closed
kjellr opened this issue Oct 29, 2021 · 3 comments · Fixed by #5012
Closed

Videomaker: Tighten up space between the H4 and paragraph on the homepage pattern. #4950

kjellr opened this issue Oct 29, 2021 · 3 comments · Fixed by #5012
Labels
[Theme] Videomaker Automatically generated label for videomaker. [Type] Bug Something isn't working
Milestone

Comments

@kjellr
Copy link
Contributor

kjellr commented Oct 29, 2021

In the block pattern used on the homepage, we should tighten up the space between the video titles and the date below them:

Before After
current intended

calc(0.5 * var(--wp--style--block-gap)) looks right to me.

(Also, I'm not sure if this is what happens in the pattern natively, but on the demo site it looks like we're using the post date block for the dates, but that doesn't make sense since these are not individual posts? cc @beafialho)

@kjellr kjellr added [Type] Bug Something isn't working [Theme] Videomaker Automatically generated label for videomaker. labels Oct 29, 2021
@kjellr kjellr added this to the Videomaker milestone Oct 29, 2021
@beafialho
Copy link
Collaborator

I agree @kjellr, tightening up spacing here is necessary

@pbking
Copy link
Contributor

pbking commented Nov 11, 2021

#5012 addresses the spacing issue you raised @kjellr, however it isn't clear what the content should be regarding your comment:

it looks like we're using the post date block for the dates, but that doesn't make sense since these are not individual posts?

It is set that way in the pattern. What value should it be if not the post date? (Which I agree doesn't make much sense...)

@kjellr
Copy link
Contributor Author

kjellr commented Nov 12, 2021

We're addressing that in #4892 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Videomaker Automatically generated label for videomaker. [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants