-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videomaker: Should grid block patterns be Query Loops? #4892
Comments
mmh, I remember solving this for Spearhead, there may be a way to hack a "featured video" for the featured image block but we'd have to evaluate how that would transfer if/when the GB issue is resolved. Maybe if the "hack" is good enough we wouldn't change anything even then. I'm going to try and think about this. |
Yeah, I'm torn about it. We could hack something in here, but really we should hold off until there's a solution to WordPress/gutenberg#27617 (comment). In the days of classic themes, we could've probably managed it, but I think we'll run into some weird issues for block themes (for example, even if we can hack it into the front end, what would the editor show? 😩). I think the easiest route for now might be to make each of those grid items videos, and then link to individual pages. For the pages themselves, we could consider using a "No featured image" page template by default, so that even if the user put a featured image in there, it wouldn't show up above the video. |
I get your point with that solution @kjellr. However, if I were a user and I was using this theme because it's a video theme, I'd expect it to be easy to upload a featured video, instead of having to add it manually, just as it is when you upload a featured image and get your latest posts automatically. Is waiting and launching the theme only when we have that functionality an option? Or getting that functionality sooner? |
We chatted about this elsewhere, but I realized we never migrated this recommendation over here. We shouldn't treat this like a blocker at all, since we can adjust the design to make it work today. I recommend that we redesign the content so that these seem less like posts and more like a grid of individual videos. I think the dates are the element that really make these seem like a grid of posts. Maybe we can change the dates to a short description instead? For example: If that still seems too much like a post, maybe something like this is better? |
Yes, we have updated the text in the pattern to have a brief description. I can't find that PR, but I remember approving it. |
Closing this in favour of #5058 |
While setting up the demo site, I noticed that the grid block patterns aren't query loops. If they were, they'd only show post featured images, because having featured videos — as mentioned in this Gutenberg issue — is not possible yet.
On top of that, if we add featured images to the posts, they will appear in the post pages, instead of showing the videos, which is the ultimate intent of this theme.
So, I wanted to ask what you think is the best approach here. Should the grid patterns be query loops? Or should the videos have manual links to the posts?
The text was updated successfully, but these errors were encountered: