Story published with empty slide frame

[megsfulton]

Steps to reproduce:

• Selected photos from device media library, published story
• Story published here: https://particular-wildcat.jurassic.ninja/2020/06/30/45/
• 5th slide is blank / empty
• When I look in the WP media library I can see that the upload failed for that image

What I expected:
If an upload for an image failed, it would trigger the error handling flow.

[megsfulton]

Tried uploading the media that failed and that didn't resolve the issue on the web viewing side. But noticed that the media library has two of the same image now so maybe it didn't fail in the first place?

First image:
https://particular-wildcat.jurassic.ninja/wp-content/uploads/2020/06/wp-1593541442772896299511300200912.jpg

Second image (uploaded on retry):
https://particular-wildcat.jurassic.ninja/wp-content/uploads/2020/06/wp-1593541442772896299511300200912-1.jpg

[mzorz]

that’s interesting! discussed elsewhere but to complete here: the error handling process we introduced for Stories will only come up when saving locally fails, but once media is all ready to be uploaded and starts its way to the server, a different error handling course (the one belonging to current WPAndroid behavior) should come into picture.

We'll look into this for sure 👍

[megsfulton]

In the second story I created using the alpha test site the 5th slide failed and I went through the error handling flow. After going through the error handling the image uploaded fine.

I don't know if this is related but figured it's worth noting since this also happened on the 5th slide.

[mzorz]

A technical note / follow up on this for myself, that might be worth exploring:

• the Gutenberg integration in WPANdroid has a package named mediauploadcompletionprocessors that holds several classes extending from BlockProcessor that might be worth exploring and implementing as well. Processors are called in replaceMediaFileWithUrlInGutenbergPost in PostUtils, which in turn is used in the MediaUploadReadyProcessor interface implementattion in replaceMediaFileWithUrlInPost() method. I'm not entirely sure if this is related to the issue, but it is part of the process of replacing local paths with final urls within the Post content so, it might be worth taking a look.

[mzorz]

note on this: given I don't see a strong relationship between the reported issue and the task described in #407 (comment) anymore (tl;dr after deeper checking realized BlockProcessor set of classes simply replaces strings just as we do so, I don't see how refactoring the code there would "fix" the reported issue). I'm leaning towards probably this issue being resolved by other fixes we did recently so, moved from in-progress back to the ToDo list, also thinking of closing it until reported again when we can get more information.