Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Hide the share button for the intro/epilogue views #555

Merged
merged 7 commits into from
Nov 30, 2022

Conversation

emilylaguna
Copy link
Contributor

πŸ“˜ Project: #376

This hides the share button on the first and last story views.

To test

  1. Launch the app
  2. Go to Profile > Tap End of Year card
  3. βœ… Verify the Share button is hidden on the first view
  4. Tap through the next stories, and βœ… verify they all show the share button
  5. βœ… Verify the Share button works and you're able to share the assets
  6. βœ… Verify the shared assets are correct for each story
  7. Go to the last view
  8. βœ… Verify the Share button is hidden

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@emilylaguna emilylaguna added the [Project] End of Year 2023 End of Year project label Nov 29, 2022
@emilylaguna emilylaguna added this to the 7.28 ❄️ milestone Nov 29, 2022
@emilylaguna emilylaguna requested a review from a team as a code owner November 29, 2022 20:51
Copy link
Contributor

@jgcaruso jgcaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks good and tests as expected! Share button isn't rendered on first or last story. Share button continues to work on middle stories and shares the correct image.

@emilylaguna emilylaguna merged commit f39fd83 into release/7.28 Nov 30, 2022
@emilylaguna emilylaguna deleted the project-eoy-376/remove-share-buttons branch November 30, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants