Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of Year: Hide "next story" text when being shared #535

Merged
merged 4 commits into from
Nov 18, 2022
Merged

End of Year: Hide "next story" text when being shared #535

merged 4 commits into from
Nov 18, 2022

Conversation

emilylaguna
Copy link
Contributor

@emilylaguna emilylaguna commented Nov 18, 2022 •
edited
Loading

📘 Project: #376

Hides the "next text" for some images when being shared. This text doesn't make much sense in the context of a static image on social media, so this hides it.

To test

  1. Launch app
  2. Go to stories
  3. Share the 3rd story to camera roll
  4. ✅ Verify the subtitle is hidden
  5. Share the 5th story to camera roll and verify the subtitle is hidden
  6. Share the last view to camera roll, verify the replay button is hidden

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@emilylaguna emilylaguna added the [Project] End of Year 2023 End of Year project label Nov 18, 2022
@emilylaguna emilylaguna added this to the 7.27 ❄️ milestone Nov 18, 2022
@emilylaguna emilylaguna requested a review from a team as a code owner November 18, 2022 17:51
@emilylaguna emilylaguna changed the title Task/eoy hide share text End of Year: Hide "next story" text when being shared Nov 18, 2022
leandroalonso
leandroalonso approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilylaguna works like a charm!

@emilylaguna emilylaguna merged commit 28095c0 into release/7.27 Nov 18, 2022
@emilylaguna emilylaguna deleted the task/eoy-hide-share-text branch November 18, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Milestone
7.27
Development

Successfully merging this pull request may close these issues.
2 participants
@emilylaguna @leandroalonso