End of Year: improve listening history sync #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandroalonso
commented
Nov 16, 2022
| @@ -205,7 +205,7 @@ class EndOfYearDataManager { | |||
| WHERE `\(DataManager.podcastTableName)`.uuid = `\(DataManager.episodeTableName)`.podcastUuid and | |||
| \(listenedEpisodesThisYear) | |||
| GROUP BY podcastUuid | |||
| ORDER BY played_episodes DESC | |||
| ORDER BY totalPlayedTime DESC | |||
There was a problem hiding this comment.
I changed that because if a person listened to, let's say, 40 episodes of a podcast that has 1-minute episodes, that would be their top podcast. Which is weird (and we already received feedback about that).
emilylaguna
suggested changes
Nov 16, 2022
| @@ -933,4 +933,8 @@ public extension DataManager { | |||
| func longestEpisode() -> Episode? { | |||
| endOfYearManager.longestEpisode(dbQueue: dbQueue) | |||
| } | |||
|
|
|||
| func episodesThatExists(uuids: [String]) -> [String] { | |||
There was a problem hiding this comment.
Suggested change
| func episodesThatExists(uuids: [String]) -> [String] { | |
| func episodesThatExist(uuids: [String]) -> [String] { |
| @@ -256,6 +256,32 @@ class EndOfYearDataManager { | |||
| return episode | |||
| } | |||
|
|
|||
| /// Given a list of UUIDs, return which UUIDs are present on the database | |||
| func episodesThatExists(dbQueue: FMDatabaseQueue, uuids: [String]) -> [String] { | |||
There was a problem hiding this comment.
Suggested change
| func episodesThatExists(dbQueue: FMDatabaseQueue, uuids: [String]) -> [String] { | |
| func episodesThatExist(dbQueue: FMDatabaseQueue, uuids: [String]) -> [String] { |
Modules/DataModel/Sources/PocketCastsDataModel/Private/Managers/EndOfYearDataManager.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Emily Laguna <[email protected]>
emilylaguna
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves and speeds up the process of syncing the 2022 listening history. I tested with an account that was taking ~6 minutes to sync. This has been reduced to ~34s. There's still room for improvement but I'll leave that for another PR.
Before the change: sync took 296.6710090637207
After the change: sync took 34.58926796913147
Improvements
The way we were doing before, we would check the database once per episode, it doesn't matter if the user had them or not. For users with a big list of episodes, the performance was very poor.
Instead, what we do now is to check the episodes that are missing and request and add only them.
To test
Checklist
CHANGELOG.mdif necessary.