Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: require account #474

Merged
merged 19 commits into from
Nov 3, 2022
Merged

Conversation

leandroalonso
Copy link
Member

@leandroalonso leandroalonso commented Nov 2, 2022

📘 Project: #376

In order to provide better End of Year stats next year, it's required to create an account to see 2022 End of Year stats.

To test

On AppDelegate.didFinishLaunchingWithOptions add (before return true):

Settings.endOfYearModalHasBeenShown = false
  1. Enable the endOfYear flag in FeatureFlag.swift
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. Logout
  4. Re-run the app
  5. ✅ The 2022 prompt should appear, even though you're logged out
  6. Tap "View my 2022"
  7. You should be prompted to login or create an account
  8. Login (or create an account)
  9. ✅ The stories should appear
  10. Remove that you added on AppDelegate and re-run the app, the prompt should not appear anymore

You should see the same behavior when tapping the card under Profile. If you're logged in, the stories should appear. If not, the login/sign up screen should appear.

Remote flag

There's a remote flag that dictates if an account is required or not to see the stories.

On AppDelegate.didFinishLaunchingWithOptions add (before return true):

Settings.endOfYearModalHasBeenShown = false

And on configureFirebase change 2.hour to 30.seconds. Then:

  1. Enable the endOfYear flag in FeatureFlag.swift
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. Logout
  4. Re-run the app
  5. ✅ The 2022 prompt should appear, even though you're logged out
  6. Go to Firebase Console > Remote Config
  7. Change end_of_year_require_account from true to false
  8. Publish the changes
  9. Remove Settings.endOfYearModalHasBeenShown = false from AppDelegate
  10. Re-run the app
  11. ✅ The prompt should appear again
  12. Tap "View my 2022"
  13. Stories should appear even though you're logged out
  14. Change end_of_year_require_account from false to true
  15. Publish the changes

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Project] End of Year 2023 End of Year project label Nov 2, 2022
@leandroalonso leandroalonso added this to the Future milestone Nov 2, 2022
@leandroalonso leandroalonso requested a review from a team as a code owner November 2, 2022 20:23
@leandroalonso leandroalonso mentioned this pull request Nov 2, 2022
36 tasks
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leandroalonso leandroalonso merged commit ff974bb into trunk Nov 3, 2022
@leandroalonso leandroalonso deleted the task/376-require-registration branch November 3, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants