-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End of Year: generate image and share it through Share Sheet #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are sheet to hang
leandroalonso
changed the base branch from
trunk
to
task/376-create-dummy-story
October 18, 2022 15:04
leandroalonso
changed the title
End of Year: generate the image and share it through a Share Sheet
End of Year: generate image and share it through Share Sheet
Oct 18, 2022
chipsnyder
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Looks good and the photo path works as expected.
Select Instagram or Facebook (story)
I don't have Instagram or Facebook set up on my test device so I wasn't able to check these paths.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the logic for image generation based on the SwiftUI story View and passes the image to the Share Sheet.
Additional details
The image generation needs to happen on the main thread — so I had to come up with a way to generate the image without affecting the presentation of the Share Sheet. If we generate the image right before the Share Sheet is presented the UI hands for a few milliseconds.
I postponed this process to right after the Share Sheet is presented. If we want to also share directly to Instagram/Facebook this process will need to apply to them too, but I'll leave that for later.
To test
I recommend testing that on a real device because on Simulator the image generation is quite quick and almost doesn't affect the main thread.
endOfYear
flag inFeatureFlag.swift
¶ You'll notice that the generated image is slightly different from the presented Story. I'll leave those tweaks for when we'll work on the final designs.
Checklist
CHANGELOG.md
if necessary.