Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of Year: add prompt #377

Merged
merged 13 commits into from
Oct 11, 2022
Merged

End of Year: add prompt #377

merged 13 commits into from
Oct 11, 2022

Conversation

leandroalonso
Copy link
Member

@leandroalonso leandroalonso commented Oct 10, 2022 •
edited
Loading

📘 Project: #376

This PR adds a modal that prompts the user to check their End of Year. Design and iPad are not covered in this task and will be done in a future PR.

To test

  1. On FeatureFlag.swift change endOfYear to true
  2. Run the app
  3. ✅ Check that a bottom sheet appears with two buttons: "View My 2022" and "Not Now"
  4. ✅ Tap "Not Now" and ensure the bottom sheet is dismissed
  5. Re-run the app
  6. When the bottom sheet appears, tap "View My 2022"
  7. ✅ Ensure a VC is shown in fullScreen mode

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Project] End of Year 2023 End of Year project label Oct 10, 2022
@leandroalonso leandroalonso requested a review from a team as a code owner October 10, 2022 19:42
@leandroalonso leandroalonso changed the title End of Year: add modal End of Year: add prompt Oct 10, 2022
leandroalonso
leandroalonso commented Oct 11, 2022
View reviewed changes
PocketCastsTests/UnitTests.xctestplan
@@ -13,6 +13,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add this to make SwiftUI previews work. 🤷

More details on the commit: 3142e08

@emilylaguna emilylaguna self-assigned this Oct 11, 2022
emilylaguna
emilylaguna approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work, I left some small nitpick comments. But they're not blockers since we're still working on this feature.

podcasts/FeatureFlag.swift Show resolved Hide resolved
podcasts/End of Year/Views/EndOfYearModal.swift Outdated Show resolved Hide resolved
@leandroalonso leandroalonso merged commit 528f72a into trunk Oct 11, 2022
@leandroalonso leandroalonso deleted the task/end-of-year-modal branch October 11, 2022 21:33
@leandroalonso leandroalonso mentioned this pull request Oct 13, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilylaguna emilylaguna emilylaguna approved these changes

Assignees

@leandroalonso leandroalonso

Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leandroalonso @emilylaguna