-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wear app to build pipeline #996
Conversation
👋 @oguzkocer ! Can you look this over? I haven't tested this. Do you have any suggestions for how to test this, or do we just wait and see what happens when we run the release script? I would like to get this merged before we do the 7.40 code freeze on Monday, May 29, if possible. |
3452640
to
b8287a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mchowning This looks good to me. We can probably improve the syntax a little bit with the addition of the third app, but it doesn't need to be in this PR and I am not an expert with Ruby anyway.
For testing, I don't think we can test the full flow, but I was able to test a big chunk of it by creating a new branch release/test-update-add-wear-to-build-pipeline
and adding a new lane in 58aa45e. This lane is almost the same as build_and_upload_to_play_store
except that it doesn't actually upload to Play Store.
I intend to delete the new branch next week, so here is the new lane:
lane :test_wear_app_changes do | options |
version = android_get_release_version()
is_beta = is_beta_version(version)
android_build_prechecks(skip_confirm: options[:skip_confirm], alpha: false, beta: is_beta, final: !is_beta) unless (options[:skip_prechecks])
android_build_preflight() unless options[:skip_prechecks]
release_assets = []
APPS.each do |app|
build_bundle(app: app, version: version)
aab_artifact_path = aab_artifact_path(app, version)
UI.error("Unable to find a build artifact at #{aab_artifact_path}") unless File.exist? aab_artifact_path
track = if (app == APPS_AUTOMOTIVE)
is_beta ? PLAY_STORE_TRACK_AUTOMOTIVE_BETA : PLAY_STORE_TRACK_AUTOMOTIVE_PRODUCTION
elsif (app == APPS_WEAR)
is_beta ? PLAY_STORE_TRACK_WEAR_BETA : PLAY_STORE_TRACK_WEAR_PRODUCTION
else
is_beta ? PLAY_STORE_TRACK_BETA : PLAY_STORE_TRACK_PRODUCTION
end
release_assets << aab_artifact_path
end
end
Thanks! I'll keep that in mind for testing the next time I do changes to the release lanes. 🙇 |
Description
Adding the the wear app to our build pipeline.
For reference, this is the PR adding the automotive build.
Testing Instructions
I don't know how to test this. Maybe @oguzkocer has some suggestions. Or we just merge it and see what happens when we try to run the release script on Monday, May 29.
Checklist
modules/services/localization/src/main/res/values/strings.xml