-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict independent watch functionality to Plus users #994
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
899c191
Limit watch to Plus users
mchowning 6e73d9c
Make sure refresh is in progress when starting LoggingInScreen
mchowning 1bf30c2
Improve comment
mchowning 68be976
Simplify logic for showing LoggingInScreen
mchowning e63bc44
Remove not-signed-in subscription status
mchowning b462224
Remove RequirePlusViewModel
mchowning 7fcf91d
Remove unused variable
mchowning cfd4965
Avoid Kotlin warning about not using assigned value
mchowning fa89591
Update UI for RequirePlusScreen
mchowning d96f4f5
Add Toast when signing into Free account on watch
mchowning f4ac9b8
Improve sign on flow logic
mchowning 151c933
Scroll to top when returning to RequirePlusScreen
mchowning 519a189
Clear previous accounts from googleSignInClient
mchowning File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change so that a user who is not logged in does not have
SubscriptionStatus.Free
. This matters because when a Plus user logs in, there is a brief period of time where the user is signed in, but we haven't gotten their subscription status from the subscription API call yet. Before this change, the user would be signed into a plus account, but the app would report their subscription status as free. With this change, we now know that we don't have their subscription status yet because it will benull
.