Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effects options to watch app #982

Merged
merged 8 commits into from
May 19, 2023
Merged

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 19, 2023

Description

This adds playback effects in the Wear OS app.

Testing Instructions

  1. Play an episode from any podcast
  2. Navigate to the player screen in the pager
  3. ✅ Notice that there is an Effects button at the bottom
  4. Tap on the Effects button
  5. ✅ Notice that the Effects screen is shown and it matches the Figma design
    (Minus button for speed is not aligned with the speed icon above it as IconButton has a minimum touch size and displays a ripple effect on tap - see timestamp 0.15 in the video)
  6. Update speed by tapping plus or minus button for speed
  7. ✅ Notice that speed is changed
  8. Toggle trim silence toggle button to on
  9. ✅ Notice that trim silence slider is shown
  10. Update trim silence by tapping plus or minus button for trim silence
  11. ✅ Notice that trim silence is changed
  12. Toggle trim silence toggle button to off
  13. ✅ Notice that trim silence slider is hidden, trim silence is set to off
  14. Turn on volume boost
  15. ✅ Notice that volume is boosted
  16. Restart the app
  17. Go to the Effects screen
  18. ✅ Notice that values selected earlier are saved

Screenshots or Screencast

Screen_recording_20230519_182004.mp4

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner May 19, 2023 13:33
@ashiagr ashiagr changed the title Add effects Add effects options on watch May 19, 2023
@ashiagr ashiagr changed the title Add effects options on watch Add effects options to watch app May 19, 2023
@mchowning mchowning added the [Area] Wear OS watch app label May 19, 2023
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly and the code looks good. Great work!

ashiagr added 2 commits May 19, 2023 21:07
# Conflicts:
#	wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/MainActivity.kt
@mchowning mchowning merged commit f5a2cff into main May 19, 2023
@mchowning mchowning deleted the task/825-now-playing-part-ii branch May 19, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants