Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update player background and add volume button #980

Merged
merged 2 commits into from
May 18, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 18, 2023

Description

This PR updates the Wear app's "Now Playing" screen to include

  • background based on the currently playing podcast
  • volume/source options

Testing Instructions

  • Play an episode from any podcast
  • Navigate to the player screen in the pager
  • ✅ Notice that the background has a tint based on the currently playing podcast
  • Notice that there is a volume button at the bottom
  • Tap on the volume button
  • ✅ Notice that the volume screen opens with a volume stepper and there's an option to select the volume source
  • Select a volume source
  • Control volume using the volume stepper
  • ✅ Notice that the volume changes for the selected source

ℹ️ The PR uses the horologist-provided volume screen, the screen needs to be updated based on Figma design.

Screenshots or Screencast

volume_.mp4

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner May 18, 2023 13:52
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Great work!

@mchowning mchowning merged commit 56f9b88 into main May 18, 2023
@mchowning mchowning deleted the task/825-now-playing-updates-part-i branch May 18, 2023 17:33
@mchowning mchowning added the [Area] Wear OS watch app label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants