Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom skip buttons not appearing #976

Merged
merged 3 commits into from
May 18, 2023
Merged

Fix custom skip buttons not appearing #976

merged 3 commits into from
May 18, 2023

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented May 18, 2023 •
edited
Loading

Description

This change fixes the issue that the media session isn't using our custom skip buttons.

Testing Instructions

  1. Play an episode
  2. Swipe down the notification shade
  3. ✅ Verify that our custom skip buttons are used in the notification player view, not the next / previous track buttons.

Screenshots

Before After
Screenshot_20230518_104156 Screenshot_20230518_104429

@geekygecko geekygecko requested a review from a team as a code owner May 18, 2023 01:20
ashiagr
ashiagr approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ashiagr ashiagr merged commit 8ab644e into release/7.39 May 18, 2023
@ashiagr ashiagr deleted the fix/custom-skip-buttons branch May 18, 2023 05:03
@ashiagr ashiagr mentioned this pull request May 18, 2023
Merged
@mchowning mchowning mentioned this pull request Jun 1, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geekygecko @ashiagr