Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Automotive account details view #975

Merged
merged 8 commits into from
May 18, 2023
Merged

Improving Automotive account details view #975

merged 8 commits into from
May 18, 2023

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented May 17, 2023 •
edited
Loading

Description

This change improves the Automotive account details section when you are both signed in and out.

This included:

  • increasing the sizes of the small fonts
  • increasing the size of the Plus badge
  • increasing the profile picture size
  • tidying up some of the constraint layouts so all the views have four anchors
  • improving the appearance of the logout button
  • improving the account created page

Fixes #966

Testing Instructions

  1. Deploy the Automotive build
  2. Tap the settings cog
  3. ✅ Verify the account details look correct
  4. Login to your account
  5. ✅ Verify the account details look correct
  6. Tap on the account button
  7. ✅ Verify the account details look correct

Screenshots

Before After
Screenshot_20230517_235728 Screenshot_20230518_080630
Screenshot_20230517_235752 automotive_signed_in_after
Screenshot_20230517_235923 automotive_set_up_account_after
Screenshot_20230518_080050 Screenshot_20230518_080452
mobile_before mobile_after
mobile_before_accounts Screenshot_20230518_090931
Screenshot_20230518_093827 Screenshot_20230518_094418
Screenshot_20230518_112710 Screenshot_20230518_120030

@geekygecko geekygecko marked this pull request as ready for review May 17, 2023 22:43
@geekygecko geekygecko requested a review from a team as a code owner May 17, 2023 22:43
ashiagr
ashiagr approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements, @geekygecko! They all look great 🥇

@ashiagr ashiagr merged commit 55c4d27 into main May 18, 2023
@ashiagr ashiagr deleted the update/automotive-account-details branch May 18, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New profile header text is very small on Android Automotive
2 participants
@geekygecko @ashiagr