Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogBuffer output to device logs screen #974

Merged
merged 2 commits into from
May 18, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented May 17, 2023

Description

When I initially implemented the device logs screen in #911, I failed to append the LogBuffer logs to the output. This PR fixes that.

Before this fix, the logs would end with the "Episode Issues" and would contain none of the timestamped logs like "I 16/5 17:31:44 App started. 7.38 (9094)".

Note
I am targeting release/7.39 with this because it seems like a pretty safe change and it would be good to get this out quickly since it fixes a new feature. I don't think we need to do a hotfix for this because emailing the logs (either from the logs display screen or if the user tries to contact support) will still include the full logs, so there is a workaround. I don't think we need to worry about immediately cutting a new beta with this—it's not urgent imo.

Testing Instructions

  1. Go to "Profile" → ⚙️ → "Help & feedback"
  2. Tap on the logs icon at the top fo the screen
  3. Verify that the screen includes the LogBuffer logs at the bottom.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml

@mchowning mchowning marked this pull request as ready for review May 17, 2023 12:02
@mchowning mchowning requested a review from a team as a code owner May 17, 2023 12:02
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, full logs are appended now. Thanks for fixing it!

@ashiagr ashiagr merged commit 3d79aaf into release/7.39 May 18, 2023
@ashiagr ashiagr deleted the fix/full-in-app-logs branch May 18, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants