Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the listening stats #960

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix the listening stats #960

merged 2 commits into from
May 15, 2023

Conversation

geekygecko
Copy link
Member

Description

The device user listening stats require a device id to keep track of the listening stats on different devices. As part of the Google single sign-on change, I removed this. 🤦‍♂️ This change puts it back.

Testing Instructions

  1. Open the Android Studio panel called 'App Inspection'
  2. Tap the 'Network Inspector' tab
  3. In the app go to the Profile tab and tap 'Refresh Now'
  4. In the 'Network Inspector' find the 'https://api.pocketcasts.net/sync/update' call
  5. ✅ Verify the request contains the device parameter with a value

Screenshot

Screenshot 2023-05-15 at 3 31 05 pm

@geekygecko geekygecko marked this pull request as ready for review May 15, 2023 06:04
@geekygecko geekygecko requested a review from a team as a code owner May 15, 2023 06:04
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the params in the inspector 👍

@ashiagr ashiagr enabled auto-merge May 15, 2023 06:17
@ashiagr ashiagr merged commit 9e6a6ca into main May 15, 2023
@ashiagr ashiagr deleted the update/stats-fix branch May 15, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants