Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the ratings feature #951

Merged
merged 3 commits into from
May 11, 2023
Merged

Enable the ratings feature #951

merged 3 commits into from
May 11, 2023

Conversation

emilylaguna
Copy link
Contributor

Description

Removes the flag to enable showing ratings for podcasts.

Testing Instructions

Follow the steps here: #868

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@emilylaguna emilylaguna added this to the 7.39 milestone May 10, 2023
@emilylaguna emilylaguna requested a review from a team as a code owner May 10, 2023 21:10
@CLAassistant
Copy link

CLAassistant commented May 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ashiagr
ashiagr approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I just added start padding to the total text in b456557

@ashiagr ashiagr enabled auto-merge May 11, 2023 04:44
@ashiagr ashiagr merged commit f45f1ad into main May 11, 2023
@ashiagr ashiagr deleted the task/enable-ratings branch May 11, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.39
Development

Successfully merging this pull request may close these issues.
3 participants
@emilylaguna @CLAassistant @ashiagr