Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide up next icons on up next screen #920

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

mchowning
Copy link
Contributor

Description

This hides the up next icons on the up next screen on the watch since the icon would be on every episode on that screen. This is also consistent with the phone's behavior.

internal discussion: p1682536583755259-slack-C040S9BK7SP

Testing Instructions

  1. Go to the Up Next screen
  2. ✅ Confirm that none of the episodes show the Up Next icon
  3. Download one of the episodes in the Up Next queue
  4. Go to the Downloads screen
  5. ✅ Confirm that the episode you just downloaded is there with both the up-next icon and the downloaded icon.

Screenshots or Screencast

Up Next Screen Downloads Screen
image image

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning added the [Area] Wear OS watch app label Apr 27, 2023
@mchowning mchowning requested a review from a team as a code owner April 27, 2023 18:34
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ashiagr ashiagr merged commit c89324d into main Apr 28, 2023
@ashiagr ashiagr deleted the update/hide-up-next-icon-on-up-next-screen branch April 28, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants