-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pager to watch app #908
Conversation
Thanks for the review!
Good question. I've been tempted to make that change a few times now, and the fact that you're bringing it up makes me think it's probably a good idea. FWIW, the phone app does dismiss the episode details screen when the user taps play. What do you think @david-gonzalez-a8c ?
The reason for that behavior is because in the first scenario the user isn't ever dismissing any of the episode screens, but in the second scenario the user is dismissing each episode screen when they swipe back to the podcast screen. The first scenario (episode screen backstack) can also happen when tapping on the episode title on the Now Playing screen. My original implementation actually only allowed a single episode screen to be in the backstack at a time, but I was worried that might get confusing as to why, in the first scenario, swiping back would never get you back to the episode you looked at earlier. Do you have any thoughts here @david-gonzalez-a8c ?
Good catch, I'll look into that and address it in a separate PR along with any of the other changes David suggests. |
I agree! In fact that was my understanding when I first reviewed the designs.
Not a super strong opinion, but I actually prefer this for the sake of simplicity (and consistency in some way). I think a good approach (as this might be a bit of an edge case) is going for the simplest behaviour, so only a 1-episode backstack and listen to user feedback if in fact becomes an issue. |
I don't think that is synced between devices (internal ref: pdeCcb-2o9-p2, and also confirmed by testing sync between two phones). That makes the fact that we don't (currently) let you customize the sort order on the watch a bit unpleasant if you don't want the default sort order. 🤔 |
Description
This adds a three screen pager to the watch app. The first page will be the current page. The second page will always be the now playing screen. The third page will always be the Up Next screen.
I initially wanted to create a
Pager
at the top level and have navigation within the first page, but it looks like that isn't really possible currently.Testing Instructions
Verify that the pager works as expected and is present on the screens you would expect. Transient notification-style screens and the Settings screen are the only ones that should not have the pager. Also check that back navigation works as expected (i.e., swiping back and swiping to exit the app).
Note that you should only be able to swipe back to the previous screen if you are on the
0
page of the pager. I did this to avoid having users tap on the episode title in the Now Playing screen, swipe to the Now Playing screen again from the episode screen, and then having swipe to dismiss take them from one Now Playing screen to their previous (identical) Now Playing screen on the previous pager.Lastly, this PR includes a somewhat-unrelated change: Tapping on the podcast name on the episode details screen should now take you to the podcast screen. (internal discussion: p1682360221894429/1682357294.725699-slack-C040S9BK7SP)
Screenshots or Screencast
Screen.Recording.2023-04-25.at.8.51.52.AM.mov
Checklist
modules/services/localization/src/main/res/values/strings.xml