Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the Automotive set skip settings accepting a blank value #892

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented Apr 19, 2023

Description

It is possible to set the Automotive skip foward and back times to an empty string. This doesn't break the skip buttons as it will use the defaults but in the UI when you open the settings it remains blank. This change improves the input validation and doesn't accept the blank value.

Testing Instructions

  1. Tap on the settings icon
  2. Tap the "Skip forward time" setting
  3. Remove the numbers so the field is blank
  4. Tap ok
  5. Tap the "Skip forward time" setting
  6. ✅ Verify the value is not blank

  1. Tap the "Skip back time" setting
  2. Remove the numbers so the field is blank
  3. Tap ok
  4. Tap the "Skip back time" setting
  5. ✅ Verify the value is not blank

  1. Tap the "Skip forward time" setting
  2. Change the skip time to another value
  3. Tap ok
  4. ✅ Verify the forward time setting summary value has changed

  1. Tap the "Skip back time" setting
  2. Change the skip time to another value
  3. Tap ok
  4. ✅ Verify the back time setting summary value has changed

  1. Tap the back button
  2. Play an episode
  3. ✅ Verify the change to the skip times has worked and the episode skips the correct amount of time

Screenshots or Screencast

Screen.Recording.2023-04-19.at.2.24.15.pm.mov

@geekygecko geekygecko marked this pull request as ready for review April 19, 2023 05:03
@geekygecko geekygecko requested a review from a team as a code owner April 19, 2023 05:03
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice fix.

@ashiagr ashiagr merged commit 645891c into main Apr 19, 2023
@ashiagr ashiagr deleted the update/automotive-blank-skips branch April 19, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants